-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allcontributors[bot] mentions himself as missing contributor #265
Comments
I see why one would ignore bots in such a list and as you mentioned, the point of All Contributors is to recognise any contributors. I guess it might be a feature some would be interested in having. |
Thinking about this a bit more, I start to understand the value of recognizing bots. Maybe we can indeed make it configurable? And/or add a new emojikey? The following idea's come to mind, no idea if it fit's all in the idea of this project, feel free to burn them at any time:
|
A configuration would be better considering that some bots cover specific categories (which may not be obvious to certain people).
Sounds doable and not too demanding on refactoring.
This would be better IMO, I guess some kind of checks would need to be considered to not have such section if there are 0 bots in the contributor's list.
Afaik bots like Dependabot, Semantic Release Bot and Snyk bot links to the main website as shown on one of my repos with all three in the table. So it does link to the bot maintainers in some way. |
Exactly what I meant. Awesome. |
Coming back to this, have you thought of a way to implement this? |
@Berkmann18 I think we can do for this is to add |
@tenshiAMD Absolutely. |
all-contributors-cli
version: 6.15.0node
version: v12.16.1npm
(oryarn
) version: 6.14.0Relevant code or config
What you did:
all-contributors
bot open a few pull-requests to get people added to the readme. (by mentioning the bot in a couple of issues)all-contributors-cli check
script at my terminal, to see if I've missed someone, it mentions that the bot itself is missing.What happened:
Reproduction repository:
Problem description:
I realize, this project is about acknowledging ALL contributors, but still. Even the bots?
Suggested solution:
Add an option to ignore bots. (or just make it the default)
The text was updated successfully, but these errors were encountered: