Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bots always on last position #166

Closed
matbrgz opened this issue Feb 8, 2019 · 10 comments
Closed

Bots always on last position #166

matbrgz opened this issue Feb 8, 2019 · 10 comments
Labels
discussion pinned status: waiting for feedback

Comments

@matbrgz
Copy link

matbrgz commented Feb 8, 2019

On contributor table bot must always be at last positions.
@Berkmann18
Copy link
Member

Would that be for all bots or just the All Contributors one?

@matbrgz
Copy link
Author

matbrgz commented Feb 8, 2019

All bots i guess.

@all-contributors all-contributors deleted a comment from allcontributors bot Feb 8, 2019
@Berkmann18
Copy link
Member

I'm okay with this.
@jakebolam @sinchang @tbenning Thoughts on that?

@jakebolam
Copy link
Collaborator

I'm open to it.

@MatheusRV what's the motivation behind this?

@matbrgz
Copy link
Author

matbrgz commented Feb 9, 2019

I'm open to it.

@MatheusRV what's the motivation behind this?

Just cosmetic for valorizate user not bots.

@jakebolam
Copy link
Collaborator

Yep. I wonder how we will enforce this?

One of the benefits right now is we don't manage order, anyone can change the array how they want and the readme file will reflect this. Forcing bots to be last would break this behaviour.

Some bots also don't report themselves as bots, and some usernames have the keyword 'bot' in it, how would we distinguish between these?

@Berkmann18
Copy link
Member

@jakebolam Perhaps, having that as a suggestion instead of a rule so it keeps the order to whoever has control over it within a repo that uses AC.

Some bots also don't report themselves as bots, and some usernames have the keyword 'bot' in it, how would we distinguish between these?

I was going to suggest, looking for an undefined/null profile URL but some bots do have one (e.g: sentinel-bot, codacy-bot).

@Berkmann18
Copy link
Member

Berkmann18 commented May 24, 2020 •
edited
Loading

@MatheusRV Have you found any better ideas other than the above?

Berkmann18 added a commit that referenced this issue May 24, 2020
@Berkmann18 @jakebolam
feat(processIssueComment): added Project Management (#166)
e2208eb 
* feat(processIssueComment): added Project Management

Added the PM category from all-contributors/all-contributors#199

* chore: updated cli and snapshots

* style(parse-comment): lint fix

* chore(update yarn.lock):
@Berkmann18
Copy link
Member

@matbrgz Have you tried any solutions for this?

@tenshiAMD
Copy link
Member

Closing this for now. Please refer to this one instead. Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion pinned status: waiting for feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jakebolam @Berkmann18 @tenshiAMD @matbrgz