Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OG thumbnail image meta data bug on A List Apart #409

Open
zeldman opened this issue Aug 26, 2017 · 5 comments
Open

OG thumbnail image meta data bug on A List Apart #409

zeldman opened this issue Aug 26, 2017 · 5 comments

Comments

@zeldman
Copy link
Member

zeldman commented Aug 26, 2017

A List Apart seems to have stopped feeding the correct image OG meta data to Twitter, with the result that tweets no longer show artwork. Compare the following two screenshots: the Facebook post picks up the first piece of art used in the content, and shows it as a thumbnail. But the tweet shows no image at all—or, rather, it shows a "missing content" image placeholder. This is like showing a "missing GIF" image as a thumbnail.

What should happen:

  • If the meta data is formatted correctly, Twitter grabs the custom illustration from an article and uses it as the thumbnail image—when the article starts with a custom illustration. (Imageus Cornellus.)
  • If the article does not start off with a custom illustration, but the meta data is formatted correctly, and the article contains body illustrations (charts, tables, screenshots, etc.) Twitter should grab a body illustration from the article body. (This is what Facebook is doing.)
  • If the article contains neither a custom illustration nor any body illustrations, and the meta data is formatted correctly, Twitter should show the ALA laurel wreath artwork—our branded default placeholder image.

google chromescreensnapz001

google chromescreensnapz002

@brettdewoody
Copy link
Contributor

Twitter now provides two options for preview cards:

  1. Summary Card

screen shot 2017-09-13 at 4 43 11 pm

  1. Summary Card with Large Image

screen shot 2017-09-13 at 4 43 23 pm

Would it be beneficial to conditionally use the Summary Card with Large Image if the article contains an article_responsive_illo (custom illustration) or body illustration, and the Summary card to display the ALA laurel wreath otherwise?

@zeldman
Copy link
Member Author

zeldman commented Sep 13, 2017

@brettdewoody

Yes, it absolutely would be!

cc @michellekondou

@zeldman zeldman self-assigned this Sep 13, 2017
@brettdewoody
Copy link
Contributor

Great.

I'd be happy to submit a PR. Or are PRs from the public not being accepted yet? I was confused by the contribution guidelines.

@zeldman
Copy link
Member Author

zeldman commented Sep 13, 2017

PRs from the public are being accepted. Sorry the guidelines are unclear. We will work on that!

cc @michellekondou

@brettdewoody
Copy link
Contributor

@zeldman @michellekondou

Unfortunately it doesn't look like there's a way to pull the first image from the article body using the built-in ExpressionEngine tags. This leaves us with:

  1. When the article starts with a custom illustration, use the custom illustration with the Summary Card with Large Image.

  2. Otherwise, use the ALA laurel wreath with the Summary Card

However, it does appear there are some EE plugins which might be able to pull the first image from the article content.

I did a search through the templates to see if either of the plugins was installed but didn't find them in use. If one of these plugins can be installed we can add the 3rd option to use the first image from the body with the Summary Card with Large Image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants