Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dist] generate release-bin tar file #247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vipamp
Copy link

@Vipamp Vipamp commented Dec 22, 2024

Purpose

Linked issue: close #246
This pr is aims to solve this feature.

Tests

API and Format

Documentation

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Vipamp, I think this will be very convenient for users to build the Fluss binary locally.


<dependencySets>
<dependencySet>
<outputDirectory>lib</outputDirectory>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the different between this assembly.xml and the existing bin.xml, opt.xml, plugins.xml? We have build fluss-xxx-bin directory. Can we just add a phase to package the directory into a .tar.gz file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,file assembly.xml is merged from bin.xml, opt.xml and plugins.xml with phase tar.gz, since adding the tar.gz phase to each file doesn't work, I add a new file and keep the original three files. If these three files are no longer required, these files will be deleted and keep assembly.xml instead,is it OK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove bin.xml, opt.xml and plugins.xml, because they are used to build fluss-${project.version}-bin directory, and the final release distribution tgz is built from this directory with additional licenses and notice. Currently, this works with the create_binary_release.sh script.

To improve maintainability, we should eliminate the redundant assembly XML definitions, which complicate maintenance. Instead, we should focus on reusing the fluss-dist/target/fluss-${project.version}-bin directory for building the local tgz.

Here is how it works in my local, you can take this commit:
wuchong@1cc0143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Generate fluss-xxx-bin.tar.gz package while building project.
2 participants