New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorToString return bad rgba string #138

Open

eco747 opened this issue Mar 19, 2020 · 0 comments

Contributor

eco747 commented Mar 19, 2020

Hi,
I think that there is a small error in ColorToString (gcanvas/gconvert.cpp)

 ss << "rgba(" << (int) color.rgba.r
           << "," << (int) color.rgba.g << "," << (int) color.rgba.b
           << "," << (int) color.rgba.a << ")"

each components are converted to int but they are in range 0.0 - 1.0
the correct code should be

 ss << "rgba(" << (int) (color.rgba.r*255.0)
           << "," << (int) (color.rgba.g*255.0)
           << "," << (int) (color.rgba.b*255.0)
           << "," << color.rgba.a
           << ")"

Regards
Etienne

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment