fix: create pipeline from dict & support pass easy_rec_config object … #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in train_and_evaluate method
|
|
|
CI PY3 TF25 Test Passed |
|
Code Style Test Passed |
|
CI PY3 Test Passed |
|
CI Test Failed |
|
CI Test Passed |
github-actions
bot
added
ci_test_passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
create_pipeline_proto_from_configsin config_util is unusable because the structure of the dictionary is inconsistent with the object structure. To improve this, we convert the dictionary to JSON first, and then use json_format in Proto to convert it to an object.The path check in
train_and_evaluatein main can be removed because the logic for checking whether the path exists is already provided by theconfig_util.get_configs_from_pipeline_filemethod. However, this method can also accept thepipeline_pb2.EasyRecConfig()object directly. Therefore, we can partially decouple and remove this redundant logic.