Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken test on develop related to dependencies issues #201

Closed
inkhey opened this issue Jun 3, 2020 · 3 comments
Closed

Fix broken test on develop related to dependencies issues #201

inkhey opened this issue Jun 3, 2020 · 3 comments
Assignees
Labels

Comments

@inkhey
Copy link
Contributor

inkhey commented Jun 3, 2020

Some test are broken in upstream due to the fact dependencies are not strict and breaking changes occured on multiple package,
to fix this we :

  1. first need to find a working combinaison of dependencies version : Fix/201 use strict dependencies version to fix tests #202
  2. in a second time, we do need to fix support for these new library version. Better dependencies handling #203, Support for upstream serpyco and apispec-serpyco #204, Support for apispec 3.+ #205, Support for upstream marshmallow #206
@inkhey
Copy link
Contributor Author

inkhey commented Jun 3, 2020

After some search:

@grignards
Copy link
Contributor

* serpyco 0.18 and later break support for hapic, error is different between serpyco version, last version (1.3) get these kind of weird error :https://travis-ci.org/github/algoo/hapic/jobs/694176233#L1478 seems like serpyco has change a lot. apispec_serpyco cannot be updated to much as latest version required a recent serpyco.

The many parameter is now given in load/dump instead of giving it to the serializer's constructor.

inkhey added a commit that referenced this issue Jun 3, 2020
- merge with master
- strict working dependencies versions

Refs: #201
@inkhey
Copy link
Contributor Author

inkhey commented Jun 3, 2020

Tests fixed,
see #203, #204, #205, #206 for better version support related issue

@inkhey inkhey closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants