Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid obsolete names for functions and types #21

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

fingolfin
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5d1cc94) 94.87% compared to head (7b6f308) 94.87%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files           6        6           
  Lines         273      273           
=======================================
  Hits          259      259           
  Misses         14       14           
Files Coverage Δ
src/algorithms/groebner-bases.jl 100.00% <ø> (ø)
src/examples/katsura.jl 97.43% <100.00%> (ø)
src/interfaces/nemo.jl 98.14% <ø> (ø)
src/types.jl 94.11% <100.00%> (ø)
src/algorithms/solvers.jl 92.18% <76.47%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ederc
Copy link
Collaborator

ederc commented Oct 19, 2023

@fingolfin Thanks!

@ederc ederc merged commit f86e10b into algebraic-solving:main Oct 19, 2023
7 checks passed
@fingolfin fingolfin deleted the mh/obsolete branch October 19, 2023 19:42
@fingolfin
Copy link
Contributor Author

@ederc could you perhaps make a new release with this in? I see that you just merged some bigger changes atop, so if that's a problem, a release made from a commit right after this PR was merged would also be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants