Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum CMake required version #8

Open
alextoind opened this issue Jun 2, 2020 · 0 comments
Open

Increase minimum CMake required version #8

alextoind opened this issue Jun 2, 2020 · 0 comments
Labels
cmake Something involves CMake enhancement New feature or request
Milestone

Comments

@alextoind
Copy link
Owner

Since #6 has been fixed by using set_target_properties() on all targets (including tests), it might be better to evaluate to increase the minimum CMake required version.

This would allow to exploit the more appropriate target_compile_features(Serial PUBLIC cxx_std_11) (available since CMake 3.8) which should also export the feature to all the targets which link to the library, e.g. the tests.

Moreover, this would also let the compiler to choose higher language standard and not only the specified version, cf. https://crascit.com/2015/03/28/enabling-cxx11-in-cmake.

@alextoind alextoind added enhancement New feature or request cmake Something involves CMake labels Jun 2, 2020
@alextoind alextoind added this to the 2.x milestone Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Something involves CMake enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant