Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide @types/material-ui-banner #8

Open
flyrev opened this issue Nov 27, 2019 · 2 comments
Open

Provide @types/material-ui-banner #8

flyrev opened this issue Nov 27, 2019 · 2 comments

Comments

@flyrev
Copy link

flyrev commented Nov 27, 2019

Using this in a React+TypeScript project, I get

error TS7016: Could not find a declaration file for module 'material-ui-banner'. 'node_modules/material-ui-banner/dist/index.js' implicitly has an 'any' type.
  Try `npm install @types/material-ui-banner` if it exists or add a new declaration (.d.ts) file containing `declare module 'material-ui-banner';`
@alexplumb
Copy link
Owner

Hi @flyrev thanks for the issue. I'm not particularly well versed in Typescript for the front-end, but I'd be happy to accept a merge request from an enterprising individual that was willing to write a d.ts file for the project.

@mattcasey
Copy link
Contributor

mattcasey commented Feb 25, 2021

Would you be interested in a Typescript rewrite instead? I'm willing to convert the files; I don't think that much would even need to change. You're using ES6 imports, webpack, etc. Having a separate .d.ts file would probably require more code, and you'd have to maintain it with any future updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants