Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector still very long after optimization #41

Open
ngallazzi opened this issue Aug 28, 2019 · 1 comment
Open

Vector still very long after optimization #41

ngallazzi opened this issue Aug 28, 2019 · 1 comment

Comments

@ngallazzi
Copy link

ngallazzi commented Aug 28, 2019

I've launched avocado on this vector:
<vector xmlns:android="http://schemas.android.com/apk/res/android" android:width="24dp" android:height="24dp" android:viewportWidth="24" android:viewportHeight="24"> <path android:pathData="M18,4C17.383,4 16.79,4.139 16.253,4.402C15.361,2.942 13.76,2 12,2C10.24,2 8.639,2.942 7.747,4.402C7.21,4.139 6.617,4 6,4C3.795,4 2,5.794 2,8C2,9.86 3.277,11.428 5,11.874L5,21C5,21.552 5.447,22 6,22L18,22C18.553,22 19,21.552 19,21L19,11.874C20.723,11.428 22,9.86 22,8C22,5.794 20.205,4 18,4ZM7,20L7,19L17,19L17,20L7,20ZM18,10C17.447,10 17,10.448 17,11L17,17L16,17L16,14L14,14L14,17L13,17L13,13L11,13L11,17L10,17L10,14L8,14L8,17L7,17L7,11C7,10.448 6.553,10 6,10C4.896,10 4,9.103 4,8C4,6.897 4.896,6 6,6C6.547,6 7.058,6.22 7.439,6.621C7.689,6.88 8.057,6.986 8.406,6.9C8.754,6.812 9.029,6.545 9.127,6.199C9.488,4.904 10.67,4 12,4C13.33,4 14.512,4.904 14.873,6.199C14.971,6.545 15.246,6.812 15.594,6.9C15.944,6.986 16.311,6.88 16.561,6.621C16.942,6.22 17.453,6 18,6C19.104,6 20,6.897 20,8C20,9.103 19.104,10 18,10Z" android:strokeWidth="1" android:fillColor="#000000" android:fillType="nonZero" android:strokeColor="#00000000"/> </vector> Unfortunately Android Studio is still telling me "long vector" even after the optimization

@emartynov
Copy link

The tool is not magic! I saw some tools approximating circles with polygons, which makes the path string enormous. I have an assumption some tweaks to avocado or exposing the approximation as parameters might help in this situation. However, it is probably also super tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants