Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make 'closed' event available to Client #14

Closed
villadora opened this issue Nov 7, 2013 · 1 comment
Closed

make 'closed' event available to Client #14

villadora opened this issue Nov 7, 2013 · 1 comment

Comments

@villadora
Copy link

Some times I want to make some cleanup after the client is closed but due to current code, Client.close() method is only push request to queue but there is no way for Client to know when the ConnectionManager just have done the work.

So I think 'closed' event is also interested by Client and should not ignored in code.

I have my own fork t to just do simple work to just emit 'closed' when the close job is done.

Please see in villadora/node-zookeeper-client@ae37fc7

@alexguan
Copy link
Owner

Please see my comments in PR #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants