diff --git a/Berksfile b/Berksfile index 5ec83e5..287b5a5 100644 --- a/Berksfile +++ b/Berksfile @@ -6,4 +6,4 @@ cookbook 'postgresql', '~> 3.4.10' cookbook 'java', '~> 1.28.0' cookbook 'git', '~> 4.1.0' cookbook 'mercurial', '~> 2.0.4' -cookbook 'subversion', '~> 1.3.0' \ No newline at end of file +cookbook 'subversion', '~> 1.3.0' diff --git a/README.md b/README.md index 76ef067..d257373 100644 --- a/README.md +++ b/README.md @@ -117,13 +117,13 @@ Gives you the ability to create TeamCity server/agent ['teamcity']['agent']['system_properties'] String - The URI of the TeamCity server. + Build Script Properties. ['teamcity']['agent']['env_properties'] String - The URI of the TeamCity server. + Environment Variables. diff --git a/attributes/default.rb b/attributes/default.rb index 26ef876..02e627f 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -37,4 +37,4 @@ default['teamcity']['agent']['work_dir'] = '../work' default['teamcity']['agent']['temp_dir'] = '../temp' default['teamcity']['agent']['system_dir'] = '../system' -end \ No newline at end of file +end diff --git a/recipes/agent.rb b/recipes/agent.rb index 017c6ad..0630ab2 100644 --- a/recipes/agent.rb +++ b/recipes/agent.rb @@ -18,7 +18,7 @@ case node['platform'] when 'windows' - include_recipe 'chef-teamcity::agent-windows' + include_recipe 'chef-teamcity::windows_agent' else - include_recipe 'chef-teamcity::agent-linux' -end \ No newline at end of file + include_recipe 'chef-teamcity::linux_agent' +end diff --git a/recipes/default.rb b/recipes/default.rb index bb48364..ca1e30f 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -22,12 +22,11 @@ include_recipe 'java' -case node['platform'] -when 'windows' - include_recipe 'git' - include_recipe 'mercurial' - include_recipe 'subversion' -else +include_recipe 'git' +include_recipe 'mercurial' +include_recipe 'subversion' + +if node['platform'] != 'windows' package 'git' package 'mercurial' package 'subversion' diff --git a/recipes/agent-linux.rb b/recipes/linux_agent.rb similarity index 100% rename from recipes/agent-linux.rb rename to recipes/linux_agent.rb diff --git a/recipes/agent-windows.rb b/recipes/windows_agent.rb similarity index 100% rename from recipes/agent-windows.rb rename to recipes/windows_agent.rb diff --git a/templates/default/buildAgent.properties.erb b/templates/default/buildAgent.properties.erb index 91ad294..d300624 100644 --- a/templates/default/buildAgent.properties.erb +++ b/templates/default/buildAgent.properties.erb @@ -28,7 +28,7 @@ systemDir=<%= @system_dir %> ## The IP address which will be used by TeamCity server to connect to the build agent. ## If not specified, it is detected by build agent automatically, ## but if the machine has several network interfaces, automatic detection may fail. -<% unless @own_address.nil? %> +<% if @own_address %> ownAddress=<%= @own_address %> <% end %>