Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CDK/TypeScript folder which contains CDKv2 code. #230

Merged
merged 12 commits into from
Feb 29, 2024

Conversation

Anirudh1612
Copy link

Added CDK/TypeScript folder which contains CDKv2 code to provision lambda power tuner.

Copy link
Owner

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🙏

I've left a few comments to address :)

@Anirudh1612
Copy link
Author

@alexcasalboni I have updated the the-lambda-power-tuner.test.ts file. It was not reflecting CDKv2, updated and tested the new code and it works fine now. Also I have removed README.md file. Will review the other changes suggested and push a new commit later.

Copy link
Owner

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments :)

.gitignore Outdated Show resolved Hide resolved
cdk/typescript/cdk.json Show resolved Hide resolved
cdk/typescript/img/state-machine-success.png Outdated Show resolved Hide resolved
cdk/typescript/img/well_architected.png Outdated Show resolved Hide resolved
cdk/typescript/lib/the-lambda-power-tuner-stack.ts Outdated Show resolved Hide resolved
cdk/typescript/template.yaml Outdated Show resolved Hide resolved
@alexcasalboni alexcasalboni mentioned this pull request Feb 27, 2024
Copy link
Owner

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few comments to address :)

.gitignore Outdated Show resolved Hide resolved
cdk/typescript/.gitignore Show resolved Hide resolved
cdk/typescript/README.md Outdated Show resolved Hide resolved
cdk/typescript/cdk.json Show resolved Hide resolved
cdk/typescript/lib/the-lambda-power-tuner-stack.ts Outdated Show resolved Hide resolved
cdk/typescript/lib/the-lambda-power-tuner-stack.ts Outdated Show resolved Hide resolved
Copy link
Owner

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we're ready to merge this 🚀

@alexcasalboni alexcasalboni merged commit ee9b230 into alexcasalboni:master Feb 29, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants