Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding admintools image tag #788

Open
chulkilee opened this issue Aug 16, 2024 · 3 comments
Open

Allow overriding admintools image tag #788

chulkilee opened this issue Aug 16, 2024 · 3 comments

Comments

@chulkilee
Copy link

chulkilee commented Aug 16, 2024

https://github.com/alexandrevilain/temporal-operator/blob/v0.19.0/internal/resource/persistence/schema_setup_job_builder.go#L126

temporalio/admintools for 1.23.1 is missing in the docker hub (link) - but temporal-operator always uses cluster version as the tag, thus I cannot deploy new cluster (unless the k8s node has the pulled image 😉 )

Probably we can do the same changes for all other images where image is configurable.

Update: reported temporalio/docker-builds#237

@alexandrevilain
Copy link
Owner

Hi!

Thanks for reporting this issue.
This will be addressed in: #760

@chulkilee
Copy link
Author

chulkilee commented Aug 16, 2024

I created PR #789 because I couldn’t wait for #760 - since it is blocking the launch of a new cluster.

@plaisted
Copy link

plaisted commented Sep 4, 2024

Got hit with this as well, was able to work around by vendoring the container with a new tag, and updating the image to point to internal repo but definitely need a way to change tags for admintools since they seem to be released with very odd tags now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants