Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Simple Exchange to not clone Agoric SDK #32

Open
sufyaankhan opened this issue Dec 7, 2023 · 0 comments
Open

Refine Simple Exchange to not clone Agoric SDK #32

sufyaankhan opened this issue Dec 7, 2023 · 0 comments

Comments

@sufyaankhan
Copy link

Today [SimpleExchange sample dapp] checks out an Agoric SDK branch to deploy and test their SimpleExchange sample dapp.

Dan and co have successfully created a Game Place Dapp. As shown in the accompanying draft getting started documentation, agoric-sdk packages are installed from NPM (using yarn) rather than by cloning the agoric-sdk repo.

We would like BytePitch to ditch cloning Agoric SDK and instead use the NPM package.

This would create a familiar dev experience from when they test the Game dapp and graduate to SimpleExchange.

Description of the Design
Use the same SimpleExchange but it is deployed and launched on Local Chain in Docker.
Security Considerations
Scaling Considerations
Test Plan

We don't test our NPM packages as much as we would like, so we would love for BytePitch to test creation of smart contracts using these packages and outline what capabilities are hindered as a developer.

Two particularly relevant changes to get the game places dapp to work without cloning and agoric install:

build(contract): update @agoric/* deps to match npm
build(contract): update endo deps to match agoric-sdk
I gather @mhofman has a suggestion to refine these slightly.

cc @michaelfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant