Add Cloudfront and ElasticBeanstalk support #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, I plan to review this this weekend. |
Closed
|
bump! |
|
Hello, what is the status of this? What is it that does not work w.r.t. Elastic Beanstalk? Thanks! |
|
It works perfectly for me, I'm using my fork in production for two seperate environments on AWS. |
|
@kageurufu Could you share anything about your configuration? Searching this repo for elasticbeanstalk doesn't suggest it's implemented - did you have to hand write this? Edit: Oh, I see you said "my fork", sorry for the noise. I still think this would be good to include. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Certificates into AWSCertificate sub-classes,
allowing for the easy adding of new listener providers
in the future. CloudFront and ElasticBeanstalk are both
implemented this way. Fix #41
Also, add the --cert-only flag, fix #13
This PR supersedes #44 and partially #17