Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] #334

Open
fforster opened this issue Apr 19, 2021 · 1 comment
Open

[FEATURE] #334

fforster opened this issue Apr 19, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@fforster
Copy link

Is your feature request related to a problem? Please describe.
When cycling between candidates with the keyboard arrows and reaching the last candidate, do not go back to the first candidate.

Describe the solution you'd like
Do nothing when reaching the last candidate. This helps when exploring a list of candidates to know when you have reached the last candidate.

Additional context
This would be useful for people checking candiates to veto every morning. It has happened to me that I don't know when to stop because I don't know when I reach the last candidate of the list.

@fforster fforster added the enhancement New feature or request label Apr 19, 2021
@dirodriguezm
Copy link
Contributor

I think you misunderstood the feature, when reaching the last candidate and press the arrow it actually fetches the next page and selects the first object of the next page.

If we implement what you are asking we would not have pagination available with arrow keys.

A suggestion is that you only query the objects you actually wanna see, and cycle through them normally and if you are on last page then it would stay in the last object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants