This repository has been archived by the owner on May 10, 2024. It is now read-only.

Confusing code structure #1

Open

ignacioreyes opened this issue Mar 10, 2020 · 0 comments

Labels

refactor

Member

ignacioreyes commented Mar 10, 2020

There is one extractor inside another but the responsibilities are not encapsulated well.
https://github.com/alercebroker/late_classifier/blob/9faa27f278f139af0b55f26a78aeda0bd961a34f/late_classifier/features/extractors/sn_non_detections_features.py#L93
In addition, storing the fid as an extra column is inappropriate.

ignacioreyes added the refactor label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.