-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different argLine for various branches (Production, Development, ...) to fully support maven-ci-friendly-versions #314
Comments
@redeamer See discussion in #305. Why do you use separate property for holding |
Hi @aleksandr-m, thanks for the quick response. Because #305 does not cover the case, that dependency versions are also using the Let's take the following pom.xml in a hotfix 1.3.1 branch: <version>${revision}${changelist}</version>
<properties>
<revision>1.3.1</revision>
<changelist>-SNAPSHOT</changelist>
</properties>
<dependencyManagement>
<dependencies>
<dependency>
...
<artifactId>dep1</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>
</dependencyManagement> Now let's assume the following revisions in the branches:
On Therefore we would need to support |
While writing the previous comment I was also looking into the plugin's code, and we run into the issue does not happen in the |
@redeamer Why there is need to use separate |
@aleksandr-m sorry for my late response, but I was off last week. |
…versioning - closes aleksandr-m#314
@aleksandr-m Opened a PR #315 |
…versioning - closes aleksandr-m#314
…versioning - closes aleksandr-m#314
…versioning - closes aleksandr-m#314
…versioning - closes aleksandr-m#314
…versioning - closes aleksandr-m#314
…versioning - closes aleksandr-m#314
…versioning - closes aleksandr-m#314
…versioning - closes aleksandr-m#314
…versioning - closes aleksandr-m#314
…versioning - closes aleksandr-m#314
…versioning - closes aleksandr-m#314
…versioning - closes aleksandr-m#314
Is there anything I could do to help getting this feature merged? :) |
Hi, first of all, thanks for the awesome work on this plugin.
We currently use gitflow-maven-plugin via CI to perform our hotfix and release start/finish tasks. We switched to use Maven CI friendly versioning, and also use it for our dependencies.
This raises the need to set the
changelist
-property to empty for builds done on master/release, but NOT change it for builds on development branches, to make sure the correct dependencies (released/snapshot) are used.Info: our provided maven repository cleans -SNAPSHOT builds, once a release build exists.
Would there be a need/want to support this? If yes, I may have time to support with an MR (after details are clarified of course).
regards m
The text was updated successfully, but these errors were encountered: