Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search with regexp fulls syntax highlight #11

Open
albfan opened this issue Jul 20, 2015 · 1 comment
Open

search with regexp fulls syntax highlight #11

albfan opened this issue Jul 20, 2015 · 1 comment

Comments

@albfan
Copy link
Owner

albfan commented Jul 20, 2015

Although some progress has been done

85a4122

search for ( which must be escaped in ag which search with regexp by default do not highlight all results

A function to escape unscaped chars is needed

"(\(|:)" --> "\((\|:\)"
"function (foo|bar)\(\)"  --> "function \(foo\|bar\)()"
@albfan albfan mentioned this issue Dec 11, 2015
Closed
amerlyq added a commit that referenced this issue Dec 15, 2015
@amerlyq
Rfc: extracted syntax file from ag#group#search
95140f4 
- Plus function was split to prepare to following refactoring
- Experimental simplification of regex escaping for highlighting

Ref #50, Ref #11
amerlyq added a commit that referenced this issue Dec 17, 2015
@amerlyq @albfan
Rfc: extracted syntax file from ag#group#search
1defc3d 
- Plus function was split to prepare to following refactoring
- Experimental simplification of regex escaping for highlighting

Ref #50, Ref #11
@albfan albfan removed the duplicate label Nov 2, 2018
Repository owner deleted a comment from amerlyq Nov 2, 2018
@albfan
Copy link
Owner Author

albfan commented Nov 2, 2018

Have to add some test for this as it is a tricky implementation easily breakable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@albfan @amerlyq