Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open crop window as soon as image is selected #44

Open
alanpich opened this issue Sep 19, 2013 · 1 comment
Open

Open crop window as soon as image is selected #44

alanpich opened this issue Sep 19, 2013 · 1 comment

Comments

@alanpich
Copy link
Owner

No description provided.

@Glidias
Copy link
Contributor

Glidias commented Sep 20, 2013

Not too sure. Currently (i think for mine version), it'll immediately show the current preview image from the editor immediately once a new image src is selected, so long as both a fixed crop width and height is provided for the TV. If the guy is happy with the preview image thumbnail as it is (default aligned top-left..), I don't think he needs to edit it further and he can save the contents immediately without touching the editor. Thus, opening the crop window automatically shouldn't necessarily be forced on the user unless absolutely necessary... If i'm not wrong, i did force opening the crop window automatically previously everytime, but figured creating the preview image immediately without force-opening the editor crop window seemed more friendly/faster. However, I can't exactly remember though, but if either the starting crop rectangle width/height is zero, the Editor crop window WILL still automatically open for such a case, since it'll be required for the user to either adjust the width/height (or both) accordingly, else no preview content will be visible. Check my version, i think it does automatically open crop window given those zero image width/height cases.

I also defined a starting editor rectangle width/height settings in the TV input settings. So, if no fixed width/height for a crop rectangle is provided (as in the above zero width/height case), the crop rectangle will start with that minimum value (or minimim 20pixels) or something for just the editor only, from what I remembered, to avoid zero dimension rects which are difficult to drag handle/locate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants