Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQ Always open anchors in same window, despite target=_blank #6

Open
renini opened this issue Feb 20, 2014 · 3 comments
Open

REQ Always open anchors in same window, despite target=_blank #6

renini opened this issue Feb 20, 2014 · 3 comments

Comments

@renini
Copy link

renini commented Feb 20, 2014

Great project! I just used this browser to create a kios mode.

What i have so far is xorg without window manager and just this browser.
But with popups on a system without a window manager is of course a bit of a mess...

Is it possible to open _blank or _new a hrefs just like if they were normal links?
So they open up in the same window.

@renini
Copy link
Author

renini commented Feb 20, 2014

Think i manage to do what i want with a simple return self in the createWindow function.

I will try to make a patch for it, there might be other use cases for it

@alandmoore
Copy link
Owner

I looked at your code; it's sound. If you wanted it merged in feel free to make a pull request. At some point I really need to clean up the interface and reduce the number of switches, but I'm not sure I want to go breaking everyone's configs. At least we still don't have as many switches as Chrome :-).

BTW I normally run mine with a window manager, usually matchbox window manager. It makes those occasional popups behave properly. Something to consider if this approach doesn't work out.

@ponchofiesta
Copy link

I used this method (return self in createWindow) for a long time now. But we found compatibility issues. Some popups are correctly opened in the same window and some not. I tried to figure out why this is not working for some popups but didn't find it.

If there will be a more reliable way to do this, it would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants