Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a deprecated clipRect() in 1.2.6 #583

Open
GoldDiggerRu opened this issue Mar 6, 2022 · 2 comments
Open

Using a deprecated clipRect() in 1.2.6 #583

GoldDiggerRu opened this issue Mar 6, 2022 · 2 comments

Comments

@GoldDiggerRu
Copy link

In the following code in WeekView.java, this line number 591

canvas.clipRect(mHeaderColumnWidth, mHeaderTextHeight + mHeaderRowPadding * 2 + mHeaderMarginBottom + mTimeTextHeight/2, getWidth(), getHeight(), Region.Op.REPLACE);

must be replaced by
canvas.clipRect(mHeaderColumnWidth, mHeaderTextHeight + mHeaderRowPadding * 2 + mHeaderMarginBottom + mTimeTextHeight/2, getWidth(), getHeight());

since the usage of Region.Op.REPLACE is no longer supported.

@Omnibruce
Copy link

This has been addressed in the 2 most recent pull requests, just desperately needs to be merged!

@GoldDiggerRu
Copy link
Author

Hi, thanks for the reply!

Will this be merged into master and the 1.2.6 release? It seems like the owner hasn't been really active, recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants