Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few UI improvements requests #133

Open
bltoby opened this issue Oct 18, 2024 · 3 comments
Open

A few UI improvements requests #133

bltoby opened this issue Oct 18, 2024 · 3 comments

Comments

@bltoby
Copy link

bltoby commented Oct 18, 2024

  1. Could you please let badukai not be stretched to fill whole screen, just leave the android system bar and status bar always visible. This will help to avoid false touches of 'play once' and 'undo move' by a lot. Or at least provide an option to let users to set what they like, full screen or with bars visible.
    IMG_20241018_022632

  2. Still the 'undo move' issue, is it possible at least pop up a confirmation request, before a move from the main game tree will be undone.

  3. If possible, add support for the landscape orientation, although not useful on a smartphone because of the small goban, but for most of time it will be better on a tablet.

  4. The special training version 1.20.3 works great, we use it quite a lot. Please don't forget to apply the UI improvements to that version too.

Thanks for the great app, cheers.

@aki65
Copy link
Owner

aki65 commented Oct 19, 2024

I have added a new setting "confirm undo" in https://github.com/aki65/aki65.github.io/releases/tag/v1.20.8 : If checked, all undos have to be confirmed.

The hiding of system bar and status bar is done by the UI framework that I use, it's delicate to interfer with that. But that should not be a problem, since the "play once" and "undo move" button don't react to upward swipes any more. So, if you swipe up to make the bars visible, no harm should be done. And even if the "undo" is triggered in some way, that I don't see at the moment, then the necessity of confirmation will prevent any data loss.

As you say, support for landscape orientation would only make sense on a tablet. But I don't have an android tablet, so I couldn't test this. Therefore, I won't do anything in that regard at the moment.

Since the changes in 1.20.8 only refer to the "undo" and "play once" button, which are disabled anyway in the "special training version", I haven't made a new "special training version".

@bltoby
Copy link
Author

bltoby commented Oct 19, 2024

I haven't realized my wrong statements about screen orientation until I have tested the crazy stone.

After comparison of it's portrait and landscape screen design, I noticed that the size of goban in both situations can be almost the same even on my phone.

1000016652
1000016653

@aki65
Copy link
Owner

aki65 commented Oct 23, 2024

People use phones primarily in portrait mode (since it is much more convenient to hold). They only switch to landscape, if they want to do something that doesn't work in portrait mode (like gaming or watching videos). So the benefit of adding a landscape layout to BadukAI would be very small. But it is a lot of work since not only the main screen has to be re-designed, all the sub-dialogs and the settings menu won't fit on a landscape display and have to be re-created. With such a ratio of benefit to work, this is just not worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants