You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd like to suggest we pick a formatter. I have always used prettier because it is well supported but, I am not as concerned about which formatter as much as the fact that we use the same one.
I will work a lot faster if I don't have to worry about spacing and trailing commas, but if I can't rely on my formatter to fix that without changing 20 other random lines of code I didn't write then the quality of PRs from me will be much lower.
Let me know if you have one in mind or if I can setup prettier along with husky to force the formatting rules before pushing.
The text was updated successfully, but these errors were encountered:
As long as we have a solution that works for both formatting and linting, then I am open to solutions. Based on working with other teams, I simply want to be sure that what gets merged is a of a consistent and enforced format. This means that one of the check points has to be that it works with the CI, so we reject anything that doesn't conform.
BTW When it comes to formatting, my philosophy is prioritise a style that facilities maintenance and readability. This means I am picky about single letter variables and making sure conditions & loops are surrounded by braces, for example. Of course there may be exceptions, such as with x, y and z, coordinates, but I prefer to minimise these situations.
I'd like to suggest we pick a formatter. I have always used prettier because it is well supported but, I am not as concerned about which formatter as much as the fact that we use the same one.
I will work a lot faster if I don't have to worry about spacing and trailing commas, but if I can't rely on my formatter to fix that without changing 20 other random lines of code I didn't write then the quality of PRs from me will be much lower.
Let me know if you have one in mind or if I can setup prettier along with husky to force the formatting rules before pushing.
The text was updated successfully, but these errors were encountered: