Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting which CRDs to install when using aiven-operator-crds chart #380

Open
mortenlj opened this issue Apr 24, 2023 · 5 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@mortenlj
Copy link
Contributor

In our cluster we want to limit which Aiven services are available to our users.
The best way to solve that would be to only install the CRDs for the services we want to allow.

Would you be open for a PR that allows selecting which services are installed with the aiven-operator-crds chart?

@byashimov byashimov added the enhancement New feature or request label Apr 25, 2023
@Serpentiel
Copy link
Contributor

hey, @mortenlj! 👋

we'll discuss this with the team and will get back to you with feedback on your idea soon

thanks!

@mortenlj
Copy link
Contributor Author

After some testing, we've found that in addition to not installing the relevant CRDs, the operator itself would need to either be configurable, or ignore services if the relevant CRD is missing in the cluster.
Currently the operator will exit the controller goroutine (but not the operator istelf) if a CRD is missing.

@byashimov
Copy link
Contributor

byashimov commented Apr 25, 2023

That's correct. It is more about configuring the operator itself. But probably there is a better option with RBAC or any other restrictions. Because it might be inventing a wheel here.

@mortenlj
Copy link
Contributor Author

Our initial approach is to use RBAC to restrict this, but as an additional measure it would be good to not have the CRD at all.
An additional point is that we see performance issues in the API server when the number of CRDs get excessive, so limiting the number of CRDs to the ones that are actually in use would be a benefit.

We will use RBAC rules for now, as this seems to be less of a "quick win" than we initially thought it would be. Feel free to close if you don't like the idea.

@byashimov
Copy link
Contributor

Limiting resource consuming is a good thing. I'll leave this opened. Thanks for the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants