From dc7d39494c72e8e939574bab0c170b8da2e1422d Mon Sep 17 00:00:00 2001
From: Murad Biashimov <murad.biashimov@aiven.io>
Date: Thu, 14 Dec 2023 12:46:16 +0100
Subject: [PATCH] chore(serviceuser): add pg test

---
 tests/serviceuser_test.go | 122 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 119 insertions(+), 3 deletions(-)

diff --git a/tests/serviceuser_test.go b/tests/serviceuser_test.go
index b51a90502..a0f5faab2 100644
--- a/tests/serviceuser_test.go
+++ b/tests/serviceuser_test.go
@@ -12,7 +12,7 @@ import (
 	"github.com/aiven/aiven-operator/api/v1alpha1"
 )
 
-func getServiceUserYaml(project, kafkaName, userName, cloudName string) string {
+func getServiceUserKafkaYaml(project, kafkaName, userName, cloudName string) string {
 	return fmt.Sprintf(`
 apiVersion: aiven.io/v1alpha1
 kind: Kafka
@@ -54,7 +54,8 @@ spec:
 `, project, kafkaName, userName, cloudName)
 }
 
-func TestServiceUser(t *testing.T) {
+// TestServiceUserKafka kafka with sasl enabled changes its port to expose
+func TestServiceUserKafka(t *testing.T) {
 	t.Parallel()
 	defer recoverPanic(t)
 
@@ -62,7 +63,7 @@ func TestServiceUser(t *testing.T) {
 	ctx := context.Background()
 	kafkaName := randName("service-user")
 	userName := randName("service-user")
-	yml := getServiceUserYaml(testProject, kafkaName, userName, testPrimaryCloudName)
+	yml := getServiceUserKafkaYaml(testProject, kafkaName, userName, testPrimaryCloudName)
 	s := NewSession(k8sClient, avnClient, testProject)
 
 	// Cleans test afterward
@@ -135,3 +136,118 @@ func TestServiceUser(t *testing.T) {
 		return err
 	}))
 }
+
+func getServiceUserPgYaml(project, pgName, userName, cloudName string) string {
+	return fmt.Sprintf(`
+apiVersion: aiven.io/v1alpha1
+kind: PostgreSQL
+metadata:
+  name: %[2]s
+spec:
+  authSecretRef:
+    name: aiven-token
+    key: token
+
+  project: %[1]s
+  cloudName: %[4]s
+  plan: startup-4
+
+---
+
+apiVersion: aiven.io/v1alpha1
+kind: ServiceUser
+metadata:
+  name: %[3]s
+spec:
+  authSecretRef:
+    name: aiven-token
+    key: token
+
+  connInfoSecretTarget:
+    name: my-service-user-secret
+    annotations:
+      foo: bar
+    labels:
+      baz: egg
+
+  project: %[1]s
+  serviceName: %[2]s
+`, project, pgName, userName, cloudName)
+}
+
+// TestServiceUserPg same as TestServiceUserKafka but runs with pg and expects the default port to be exposed
+func TestServiceUserPg(t *testing.T) {
+	t.Parallel()
+	defer recoverPanic(t)
+
+	// GIVEN
+	ctx := context.Background()
+	pgName := randName("connection-pool")
+	userName := randName("connection-pool")
+	yml := getServiceUserPgYaml(testProject, pgName, userName, testPrimaryCloudName)
+	s := NewSession(k8sClient, avnClient, testProject)
+
+	// Cleans test afterwards
+	defer s.Destroy()
+
+	// WHEN
+	// Applies given manifest
+	require.NoError(t, s.Apply(yml))
+
+	// Waits kube objects
+	pg := new(v1alpha1.PostgreSQL)
+	require.NoError(t, s.GetRunning(pg, pgName))
+
+	user := new(v1alpha1.ServiceUser)
+	require.NoError(t, s.GetRunning(user, userName))
+
+	// THEN
+	// Validates PostgreSQL
+	pgAvn, err := avnClient.Services.Get(ctx, testProject, pgName)
+	require.NoError(t, err)
+	assert.Equal(t, pgAvn.Name, pg.GetName())
+	assert.Equal(t, "RUNNING", pg.Status.State)
+	assert.Equal(t, pgAvn.State, pg.Status.State)
+	assert.Equal(t, pgAvn.Plan, pg.Spec.Plan)
+	assert.Equal(t, pgAvn.CloudName, pg.Spec.CloudName)
+
+	// Validates ServiceUser
+	userAvn, err := avnClient.ServiceUsers.Get(ctx, testProject, pgName, userName)
+	require.NoError(t, err)
+	assert.Equal(t, userName, user.GetName())
+	assert.Equal(t, userName, userAvn.Username)
+	assert.Equal(t, pgName, user.Spec.ServiceName)
+
+	// Validates Secret
+	secret, err := s.GetSecret("my-service-user-secret")
+	require.NoError(t, err)
+	assert.NotEmpty(t, secret.Data["HOST"])
+	assert.NotEmpty(t, secret.Data["PORT"])
+	assert.NotEmpty(t, secret.Data["USERNAME"])
+	assert.NotEmpty(t, secret.Data["PASSWORD"])
+	assert.NotEmpty(t, secret.Data["CA_CERT"])
+	assert.Contains(t, secret.Data, "ACCESS_CERT")
+	assert.Contains(t, secret.Data, "ACCESS_KEY")
+	assert.NotEmpty(t, secret.Data["SERVICEUSER_HOST"])
+	assert.NotEmpty(t, secret.Data["SERVICEUSER_PORT"])
+	assert.NotEmpty(t, secret.Data["SERVICEUSER_USERNAME"])
+	assert.NotEmpty(t, secret.Data["SERVICEUSER_PASSWORD"])
+	assert.NotEmpty(t, secret.Data["SERVICEUSER_CA_CERT"])
+	assert.Contains(t, secret.Data, "SERVICEUSER_ACCESS_CERT")
+	assert.Contains(t, secret.Data, "SERVICEUSER_ACCESS_KEY")
+	assert.Equal(t, map[string]string{"foo": "bar"}, secret.Annotations)
+	assert.Equal(t, map[string]string{"baz": "egg"}, secret.Labels)
+
+	// Default port is exposed
+	assert.NotEmpty(t, pgAvn.URIParams["port"])
+	assert.Equal(t, pgAvn.URIParams["port"], string(secret.Data["PORT"]))
+
+	// We need to validate deletion,
+	// because we can get false positive here:
+	// if service is deleted, pool is destroyed in Aiven. No service — no pool. No pool — no pool.
+	// And we make sure that the controller can delete db itself
+	assert.NoError(t, s.Delete(user, func() error {
+		_, err = avnClient.ServiceUsers.Get(ctx, testProject, pgName, userName)
+		return err
+	}))
+}