Align with community image overrides format #576
Labels
2-Manifests
Relates to manifest/document set related issues
priority/low
Items that are considered non-critical for functionality, such as quality of life improvements
size m
Milestone
Problem description (if applicable)
The charts in this repository have an image overrides format which uses a format such as:
https://github.com/airshipit/charts/blob/510ead0632c880e8bb61cff55fa1f0077bf4bcaf/charts/dex-aio/values.yaml#L7-L10
instead of the more common format from the community:
https://github.com/prometheus-community/helm-charts/blob/5f585df3bc13ab525f3841638f939f9fab018ecf/charts/kube-state-metrics/values.yaml#L3-L6
the versions catalog attempts to smooth over the differences:
airshipctl/manifests/function/airshipctl-schemas/airshipit.org_versionscatalogues.yaml
Lines 169 to 180 in 7cfffde
but the "repository"/"repo" difference means that replacement rules can't simply plug in all the images with a single rule, and instead rules for each image/field are needed:
https://review.opendev.org/c/airship/treasuremap/+/791835/25/manifests/function/dex-aio/replacements/update-dex.yaml#30
Proposed change
One of the following:
image_components
andimage_components_airship
.Potential impacts
If we go with 1. then any consumers of these charts will need to be updated to match the new name.
The text was updated successfully, but these errors were encountered: