You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Type mock_argument_t is generic. It is not appropriate to store va_list parameters.
When we store parameters, we have lost the type. We should do something earlier, maybe some macro magic.
There is a aum_parameter_type in aum/assert.h and also in aum/mock.h, they should be unified.
Maybe we need to store the type as a string and parse it ? Maybe we should convert the type into a structure with all the function pointers appropriate to handle the type, as soon as possible in the code.
Anyway, as of today, this is hacky.
Also, I am not really happy that the user has to specify AUM_PARAMETER_STRING or AUM_PARAMETER_RAW when using AUM_ASSERT_WAS_CALLED_WITH.
The text was updated successfully, but these errors were encountered:
Since, we know the mock arguments type, it should not be necessary for the user to specify them again when doing its assert with aum_mock_was_called_with. Look, how the code of aum_mock_was_called_with could depend on an information stored with the mock.
Type mock_argument_t is generic. It is not appropriate to store va_list parameters.
When we store parameters, we have lost the type. We should do something earlier, maybe some macro magic.
There is a aum_parameter_type in aum/assert.h and also in aum/mock.h, they should be unified.
Maybe we need to store the type as a string and parse it ? Maybe we should convert the type into a structure with all the function pointers appropriate to handle the type, as soon as possible in the code.
Anyway, as of today, this is hacky.
Also, I am not really happy that the user has to specify AUM_PARAMETER_STRING or AUM_PARAMETER_RAW when using AUM_ASSERT_WAS_CALLED_WITH.
The text was updated successfully, but these errors were encountered: