Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove types and members marked obsolete in 1.x. #19

Open
airbreather opened this issue Jul 22, 2019 · 1 comment
Open

Remove types and members marked obsolete in 1.x. #19

airbreather opened this issue Jul 22, 2019 · 1 comment

Comments

@airbreather
Copy link
Owner

Throughout the development of 1.x, I've made some mistakes that can only be completely fixed by one or more intentional breaking changes. I intend to follow SemVer 2.0.0, so the most that a 1.x version can do to fix these mistakes is to provide the correct alternatives and mark the incorrect ones as obsolete.

According to SemVer 2.0.0, breaking changes are allowed as long as the major version is incremented, so let's make sure that Cursively 2.0.0 finishes fixing these mistakes.

@airbreather
Copy link
Owner Author

I keep briefly forgetting this... the "behavior breaking change" label is because instead of removing the header-aware visitor's default constructor, I'm actually intending to remove the [Obsolete] tag and having it act the same as what it suggests users should do instead.

Technically it's "remove the obsolete default constructor" followed immediately by "add a default constructor that behaves correctly", but since both have to happen at once in order for me to fulfill my goals, a watchful outsider would consider this to be a "behavior breaking change", so I'm counting it.

@airbreather airbreather added usability Make the library easier to use enhancement New feature or request labels Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant