Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary incompatibility between 6.3.0 and 6.4.0 #2479

Closed
carlonzo opened this issue Mar 12, 2024 · 2 comments
Closed

Binary incompatibility between 6.3.0 and 6.4.0 #2479

carlonzo opened this issue Mar 12, 2024 · 2 comments

Comments

@carlonzo
Copy link

Describe the bug
We recently updated in our app to 6.4.0 and we received crashes running from libraries compiled against 6.3.0

Here is a stacktrace from the crash

java.lang.NoSuchMethodError: No static method LottieAnimation(Lcom/airbnb/lottie/LottieComposition;Landroidx/compose/ui/Modifier;ZZLcom/airbnb/lottie/compose/LottieClipSpec;FIZZZLcom/airbnb/lottie/RenderMode;ZZLcom/airbnb/lottie/compose/LottieDynamicProperties;Landroidx/compose/ui/Alignment;Landroidx/compose/ui/layout/ContentScale;ZZLjava/util/Map;Lcom/airbnb/lottie/AsyncUpdates;Landroidx/compose/runtime/Composer;III)V in class Lcom/airbnb/lottie/compose/LottieAnimationKt; or its super classes (declaration of 'com.airbnb.lottie.compose.LottieAnimationKt' appears in /data/app/com.careem.acma.qa-zL-fH-NABMFzbpoValaHgg==/base.apk!classes3.dex)

We had similar issue when we bumped from 6.2.0 to 6.3.0 but did not raise a bug.

Steps To Reproduce
Compile a library using Lottie 6.3.0 using LottieAnimation and run the code using 6.4.0 at runtime

@gpeal
Copy link
Collaborator

gpeal commented Mar 12, 2024

The original assumption from this issue was that @JvmOverloads would be sufficient here. However, it became clear that it was not. I added a binary compatibility checker to prevent this in the future. Sorry for the overhead here.

@gpeal gpeal closed this as completed Mar 12, 2024
@carlonzo
Copy link
Author

thanks for that. that will help!
are we going to expect a patch on 6.4.0 to bring compatibility with 6.3.0, or we just need for everyone to jump on 6.4.0 first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants