Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose forceLayout in EpoxySwiftUIHostingView #172

Merged

Conversation

zetasq
Copy link
Contributor

@zetasq zetasq commented Aug 14, 2024

Change summary

Expose forceLayout in EpoxySwiftUIHostingView

How was it tested?

How did you verify that this change accomplished what you expected? Add more detail as needed.

  • Wrote automated tests
  • Built and ran on the iOS simulator
  • Built and ran on a device

Pull request checklist

All items in this checklist must be completed before a pull request will be reviewed.

  • Risky changes have been put behind a feature flag, e.g. CollectionViewConfiguration
  • Added a CHANGELOG.md entry in the "Unreleased" section for any library changes

@zetasq zetasq force-pushed the expose-forceLayout-in-EpoxySwiftUIHostingView branch from 57cb148 to 19bc7df Compare August 14, 2024 07:30
@@ -246,6 +241,12 @@ public final class EpoxySwiftUIHostingView<RootView: View>: UIView, EpoxyableVie
}
}

public func forceLayout() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add doc comments to this function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. Added the usage description.

@zetasq zetasq requested a review from brynbodayle August 15, 2024 01:13
@zetasq zetasq force-pushed the expose-forceLayout-in-EpoxySwiftUIHostingView branch from c781f04 to b3dd08d Compare August 15, 2024 01:14
@zetasq
Copy link
Contributor Author

zetasq commented Aug 21, 2024

Hi @brynbodayle , could you help to merge this PR? Thanks.

@brynbodayle brynbodayle merged commit 93178a5 into airbnb:master Aug 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants