Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visionOS SwiftUI bar interaction #167

Merged

Conversation

bryankeller
Copy link
Contributor

Change summary

This works around a visionOS bug that causes SwiftUI views contained in hosting controllers to have broken interaction if their zPosition's magnitude is too large. A safe workaround is to ensure that zPosition is always between -1 and 1, which provides ample precision for all of our needs.

How was it tested?

How did you verify that this change accomplished what you expected? Add more detail as needed.

  • Wrote automated tests
  • Built and ran on the iOS simulator
  • Built and ran on a device

Pull request checklist

All items in this checklist must be completed before a pull request will be reviewed.

  • Risky changes have been put behind a feature flag, e.g. CollectionViewConfiguration
  • Added a CHANGELOG.md entry in the "Unreleased" section for any library changes

@bryankeller bryankeller requested a review from brynbodayle April 16, 2024 20:17
@bryankeller bryankeller added the bug Something isn't working label Apr 16, 2024
@bryankeller bryankeller merged commit 688aed5 into airbnb:master Apr 16, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants