Add view builder closures for custom views #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryankeller
commented
Sep 18, 2023
| @@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Added a `multiDaySelectionDragHandler`, enabling developers to implement multiple-day-selection via a drag gesture (similar to multi-select in the iOS Photos app) | |||
| - Added the ability to change the aspect ratio of individual day-of-the-week items | |||
| - Added support for self-sizing month headers | |||
| - Added a new `setContent(_:animated:)` function, allowing people to perform animated content updates | |||
| - Added a new `setContent(_:animated:)` function, enabling developers to perform animated content updates | |||
There was a problem hiding this comment.
Head Lead of Developer Enablement
brynbodayle
previously approved these changes
Sep 18, 2023
bryankeller
force-pushed
the
bk/improve-swiftui-api
branch
from
3db3f99 to
a123e20
Compare
bryankeller
force-pushed
the
bk/improve-swiftui-api
branch
from
a123e20 to
c16beff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This adds new APIs to
CalendarViewRepresentablefor customizing the day views, month header views, etc. These new APIs allow developers to work with SwiftUI view directly, without needing to convert to aCalendarItemModel<SwiftUIWrapperView>first.As of right now, most of the SwiftUI support is undocumented in the README. I'll be working on revamping the docs next.
Related Issue
N/A
Motivation and Context
More idiomatic SwiftUI API.
How Has This Been Tested
Example app.
Types of changes
Checklist