Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SwiftUI sizing #267

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Improve SwiftUI sizing #267

merged 1 commit into from
Sep 17, 2023

Conversation

bryankeller
Copy link
Contributor

Details

Improve SwiftUI sizing. Rather than returning .infinity from the sizing functions when the proposed size is (nil, nil), we return a reasonable minimum size instead. This fixes an issue that causes a vertical CalendarViewRepresentable to freeze the app when displayed in a VStack / LazyVStack

Related Issue

N/A

Motivation and Context

Crash fix, also prevents some warning logs about infinite dimensions.

How Has This Been Tested

Example app

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@bryankeller bryankeller added the bug Something isn't working label Sep 16, 2023
@bryankeller bryankeller merged commit 2c843d7 into master Sep 17, 2023
2 checks passed
@bryankeller bryankeller deleted the bk/improve-swiftui-sizing branch September 18, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants