diff --git a/CHANGES.rst b/CHANGES.rst index 771b5033..d9b776d9 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,5 +1,10 @@ Changes ------- + +1.0.3 (2020-04-09) +^^^^^^^^^^^^^^^^^^ +* Fixes typo when using credential process + 1.0.2 (2020-04-05) ^^^^^^^^^^^^^^^^^^ * Disable Client.__getattr__ emit for now #789 diff --git a/aiobotocore/__init__.py b/aiobotocore/__init__.py index 4345f0e2..4680261f 100644 --- a/aiobotocore/__init__.py +++ b/aiobotocore/__init__.py @@ -1,4 +1,4 @@ from .session import get_session, AioSession __all__ = ['get_session', 'AioSession'] -__version__ = '1.0.2' +__version__ = '1.0.3' diff --git a/aiobotocore/credentials.py b/aiobotocore/credentials.py index a5b15898..a1c530d6 100644 --- a/aiobotocore/credentials.py +++ b/aiobotocore/credentials.py @@ -425,7 +425,7 @@ async def _retrieve_credentials_using(self, credential_process): # We're not using shell=True, so we need to pass the # command and all arguments as a list. process_list = compat_shell_split(credential_process) - p = await self._popen(process_list, + p = await self._popen(*process_list, stdout=subprocess.PIPE, stderr=subprocess.PIPE) stdout, stderr = await p.communicate() diff --git a/tests/botocore/test_credentials.py b/tests/botocore/test_credentials.py index ecbe17e8..d41c773a 100644 --- a/tests/botocore/test_credentials.py +++ b/tests/botocore/test_credentials.py @@ -931,7 +931,7 @@ def _f(profile_name='default', loaded_config=None, invoked_process=None): @pytest.mark.moto @pytest.mark.asyncio async def test_processprovider_retrieve_refereshable_creds(process_provider): - config = {'profiles': {'default': {'credential_process': 'my-process'}}} + config = {'profiles': {'default': {'credential_process': 'my-process /somefile'}}} invoked_process = mock.AsyncMock() stdout = json.dumps({ 'Version': 1, @@ -955,7 +955,7 @@ async def test_processprovider_retrieve_refereshable_creds(process_provider): assert creds.access_key == 'foo' assert creds.secret_key == 'bar' assert creds.token == 'baz' - popen_mock.assert_called_with(['my-process'], + popen_mock.assert_called_with('my-process', '/somefile', stdout=subprocess.PIPE, stderr=subprocess.PIPE)