Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring docker CI tests back for PRs from forked repo #6449

Closed
unkcpz opened this issue Jun 4, 2024 · 2 comments · Fixed by #6451
Closed

Bring docker CI tests back for PRs from forked repo #6449

unkcpz opened this issue Jun 4, 2024 · 2 comments · Fixed by #6451
Labels
type/feature request status undecided

Comments

@unkcpz
Copy link
Member

unkcpz commented Jun 4, 2024

#6396 refactoring docker CI by not upload the artifact but directly push image to ghcr.io registry, which accelerate the CI time a lot.
However, push to ghcr.io requires the write permission of GITHUB_TOKEN which is not available for the PR from forked repo. Thus it unfortunately cut the feature to have the built image tested from forked repo which can grab some issue as manifested and fixed in #6445

@unkcpz unkcpz added the type/feature request status undecided label Jun 4, 2024
@sphuber
Copy link
Contributor

sphuber commented Jun 4, 2024

@unkcpz If you implement this, would that make #6446 obsolete?

@unkcpz
Copy link
Member Author

unkcpz commented Jun 4, 2024

Yes, but I may not able to do it now. So maybe finish #6446 and keep this issue open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature request status undecided
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants