Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version v2.2.0 -> v2.2.1 #598

Merged
merged 1 commit into from
May 5, 2024
Merged

Bump version v2.2.0 -> v2.2.1 #598

merged 1 commit into from
May 5, 2024

Conversation

danielhollas
Copy link
Contributor

@superstar54 I am assuming you want to make a new AWB release to include #597?
Is there something else that needs fixing?

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (1bba240) to head (9834dad).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #598   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files          11       11           
  Lines        1188     1188           
=======================================
  Hits         1143     1143           
  Misses         45       45           
Flag Coverage Δ
python-3.10 96.21% <ø> (ø)
python-3.9 96.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 self-requested a review May 4, 2024 19:21
@superstar54
Copy link
Member

Thanks for reaching out, @danielhollas. @AndresOrtegaGuerrero and I recently discussed the possibility of releasing a new version of AWB, especially considering the inclusion of #597. While we see the value in a new release, AWB 2.2.0 was just launched, and we didn't want to impose by requesting another so soon. We truly appreciate your initiative to consider another release and are grateful for your support.

@superstar54
Copy link
Member

superstar54 commented May 4, 2024

Is there something else that needs fixing?

Nothing else from my side. @AndresOrtegaGuerrero , do you have anything in mind?

@AndresOrtegaGuerrero
Copy link
Member

Is there something else that needs fixing?

Nothing else from my side. @AndresOrtegaGuerrero , do you have anything in mind?

No, thank you @danielhollas !

@danielhollas danielhollas merged commit 7ce8d02 into master May 5, 2024
15 checks passed
@danielhollas danielhollas deleted the release/2.2.1 branch May 5, 2024 09:25
@superstar54
Copy link
Member

Hi @danielhollas , it seems that the AWB 2.2.1 has not been officially released.

@danielhollas
Copy link
Contributor Author

@superstar54 thank you for the reminder, it is released now. https://pypi.org/project/aiidalab-widgets-base/

While we see the value in a new release, AWB 2.2.0 was just launched, and we didn't want to impose by requesting another so soon.

No problem at all, this is what what patch releases are for, and this bugfix seemed important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants