Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow register different viewers for different WorkChain. #541

Merged
merged 10 commits into from
Apr 23, 2024
Merged

Allow register different viewers for different WorkChain. #541

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
145f5c0
use `process_type` as the node viewer's key
superstar54 Nov 20, 2023
a478890
fix default process node viewer
superstar54 Nov 20, 2023
74ef2a1
add backward capacity
superstar54 Nov 20, 2023
e5c883a
fix test_computational_resources.py
superstar54 Nov 21, 2023
e335734
Merge branch 'master' into fix/540/use_process_label_for_viewer
danielhollas Jan 22, 2024
cd0bac9
Merge branch 'master' into fix/540/use_process_label_for_viewer
danielhollas Mar 17, 2024
ca9a17a
Simplify logic
danielhollas Mar 17, 2024
94a22f6
Merge branch 'master' into fix/540/use_process_label_for_viewer
danielhollas Apr 10, 2024
78a7b3f
Merge branch 'master' into fix/540/use_process_label_for_viewer
superstar54 Apr 23, 2024
763d84e
Test loading a viewer widget based on the process type of the process…
superstar54 Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions aiidalab_widgets_base/viewers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,12 @@ def viewer(obj, **kwargs):
)
return obj

if obj.node_type in AIIDA_VIEWER_MAPPING:
_viewer = AIIDA_VIEWER_MAPPING[obj.node_type]
_viewer = AIIDA_VIEWER_MAPPING.get(obj.node_type)
if isinstance(obj, orm.ProcessNode):
# Allow to register specific viewers based on obj.process_type
_viewer = AIIDA_VIEWER_MAPPING.get(obj.process_type, _viewer)

if _viewer:
return _viewer(obj, **kwargs)
else:
# No viewer registered for this type, return object itself
Expand Down