Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow register different viewers for different WorkChain. #541

Merged
merged 10 commits into from
Apr 23, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Nov 20, 2023

Fix #540 , use process_type as the node viewer's key.

Here is an example, aiidalab/aiidalab-qe#559

@danielhollas
Copy link
Contributor

I think this will need some discussion, since it would be a breaking change?

@superstar54 superstar54 force-pushed the fix/540/use_process_label_for_viewer branch from 3801b3d to 74ef2a1 Compare November 20, 2023 15:52
@superstar54
Copy link
Member Author

Now it has backward capacity. I agree we need more discussion on it.

@danielhollas
Copy link
Contributor

Thanks @superstar54. Can you take a look at the failing tests? Looks like the failures might not be related to this PR, but should be fixed regardless.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (826ad43) to head (763d84e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   96.17%   96.21%   +0.03%     
==========================================
  Files          11       11              
  Lines        1177     1188      +11     
==========================================
+ Hits         1132     1143      +11     
  Misses         45       45              
Flag Coverage Δ
python-3.10 96.21% <100.00%> (+0.03%) ⬆️
python-3.9 96.21% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54
Copy link
Member Author

The failed test is caused by a update in the template in aiida-resource-registry repo, which add a new version field.
I fixed it.

@danielhollas
Copy link
Contributor

@superstar54 thank you for fixing the test. Could you please make a separate PR with that fix? I assume the test failures would pop up on other PRs as well?

Does this PR need to be merged for 2.1.0 version?

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've thought about this a bit more and it seems like a good feature to have.
The only thing missing here is a unit test for the new behaviour.

@superstar54
Copy link
Member Author

The only thing missing here is a unit test for the new behaviour.

Hi @danielhollas , I added a unit test for this behavior. Could you please have a look?

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@superstar54 perfect, thanks!

@superstar54 superstar54 merged commit 67df249 into master Apr 23, 2024
11 checks passed
@superstar54 superstar54 deleted the fix/540/use_process_label_for_viewer branch April 23, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not register different viewers for different WorkChain.
2 participants