Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment and Generator issues #33

Open
akolonin opened this issue Nov 15, 2021 · 0 comments
Open

Segment and Generator issues #33

akolonin opened this issue Nov 15, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@akolonin
Copy link
Member

akolonin commented Nov 15, 2021

Issues:

  1. Need to eliminate all "shortcuts" from the mainstream Segment and Generator сode so it refers to the LG rules only and not relies on the individual words from the examples or test corpora. For instance, like this:

    if (mid.toLowerCase().equals("a") && right.equals("is"))

    The code should work without based just on LG data, not "if"-s referring to specific tokens.

  2. Can not use Generator following the instructions in https://github.com/aigents/aigents-java-nlp/#build-script - I see that Segment seems working but Generator is not:

(env) Antons-MacBook-Pro:src akolonin$ java main.java.org.aigents.nlp.gen.Segment en/4.0.dict tuna is a fish eagle is a bird dog is a mammal
tuna is a fish eagle is a bird dog is a mammal: [Tuna is a fish., Eagle is a bird., Dog is a mammal.]

(env) Antons-MacBook-Pro:src akolonin$ java main.java.org.aigents.nlp.gen.Generator en/4.0.dict fish tuna is a
[fish, tuna, is, a]: []
  1. Potentially, Generator and Segment can be re-factored to use new "LG-based-only" LG parser only Added LG parser #32

  2. Package naming policy should be changed to canonical form, so "package main.java.org.aigents.nlp.gen;" becomes "package org.aigents.nlp.gen;"

@akolonin akolonin added the bug Something isn't working label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants