Magnetic disturbances #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now in my own fork instead of Moana's)
…erence frame transformation function
…unction to form this transformation matrix)
…of floats, outputs: numpy arrays (needs to be reviewed in implementation)
…l and magnetic) on actor. started with set_attitude_model and attitude model class as well.
…access the I-matrix)
deleted redundant function (which I added myself)
pointing vector function
# Conflicts: # paseos/attitude/attitude_model.py # test_attitude_code/test_attitude_plotting.py
# Conflicts: # paseos/attitude/attitude_model.py # paseos/tests/attitude_test.py
Mr-Medina
added
tests
Mr-Medina
requested review from
gomezzz and
GabrieleMeoni
and removed request for
gomezzz
GabrieleMeoni
requested changes
Jan 30, 2024
paseos/attitude/attitude_model.py
Outdated
| u = np.array(self._actor.get_position(self._actor.local_time)) | ||
| return -u / np.linalg.norm(u) | ||
|
|
||
| def _earth_magnetic_dipole_moment(self): |
There was a problem hiding this comment.
This is a feature of the center body. I would move it there
There was a problem hiding this comment.
That is true, I put it in central_body. I put a todo to implement other central bodies instead of Earth, I can remove that todo and add an issue later (or don't do any). Is this okay?
paseos/tests/attitude_test.py
Outdated
| # get Earth B vector at specific timestep | ||
|
|
||
| # Earth magnetic dipole moment: | ||
| m_earth = actor._attitude_model.earth_magnetic_dipole_moment() |
There was a problem hiding this comment.
I would not make it a property of the attitude model but of the central body, as mentioned before.
GabrieleMeoni
approved these changes
Jan 31, 2024
|
@Mr-Medina please notice that your test on the magnetic disturbances is failing me. It passes only if I use at least |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Resolved Issues
How Has This Been Tested?
Place two actors in GEO orbit in the magnetic dipole moment vector plane of the Earth, one magnetic, one non-magnetic. Alligning body pointing vectors (and for the magnetic actor: its magnetic dipole) with the local field vector of the Earth. Run simulation and check if magnetic actor follows field lines, and non-magnetic actor doesn't change attitude.
Related Pull Requests
Complements the general attitude model.