Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ranking algorithm for triggers with no words #94

Closed
htdinh opened this issue May 31, 2017 · 2 comments
Closed

Improve ranking algorithm for triggers with no words #94

htdinh opened this issue May 31, 2017 · 2 comments

Comments

@htdinh
Copy link
Contributor

htdinh commented May 31, 2017

  1. Issue: The current sorting algorithm fails again when the trigger with no text (trigger 2 below) takes precedence over the trigger with text (trigger 1). This undesired sorting is not seen in both Python release v1.14.4 (prior to new sorting algorithm) and JavaScript version (tested in https://www.rivescript.com/try).
+ hi [*]
- 1
+ _ _
- 2
  1. Explanation of the behaviour: This is because the binary presence of words (yes, no) is not taken properly. This was handled with star such that single star * and its variance [*] would be placed last in the sorting.
  2. Solution: Create a new variable to indicate the presence of words. Make this the first sorting criteria. Within each group (with and without words), we apply the old sorting algorithm.
htdinh pushed a commit to htdinh/rivescript-python that referenced this issue May 31, 2017
aichaos#94 Adding optionals to be delimiter for word count of triggers
f80a14e
htdinh pushed a commit to htdinh/rivescript-python that referenced this issue May 31, 2017
aichaos#94 Adding new attribute is_empty to indicate the presence of …
cb375a5 
…words in trigger and take this attr into consideration of multi-sorting
htdinh pushed a commit to htdinh/rivescript-python that referenced this issue May 31, 2017
aichaos#94 Add unit test to cover trigger with no text
ef599b6
htdinh pushed a commit to htdinh/rivescript-python that referenced this issue May 31, 2017
aichaos#94 Add unit test for sorting trigger with weights tag. Minor …
1e2213e 
…update on comment
htdinh pushed a commit to htdinh/rivescript-python that referenced this issue May 31, 2017
aichaos#94 Revert minor spelling error in comment due to auto-refractor
59416cd
@htdinh
Copy link
Contributor Author

htdinh commented May 31, 2017

The change in this issue would also change the ranking order of [*] and *, which is recently handled in #92. Since the two triggers are serving the same purpose (match any string including empty one), they should not appear in the same script, therefore the order between them is not strict as long as they both secure the last places in the ranking.

kirsle added a commit that referenced this issue May 31, 2017
@kirsle
Merge pull request #95 from Dinh-Hung-Tu/#94
a4f4fd6 
#94 Improve ranking algorithm
@kirsle
Copy link
Member

kirsle commented May 31, 2017

Fixed in PR #95

@kirsle kirsle closed this as completed May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kirsle @htdinh