From 6b417297d11b2a2bfe7a2eb00c77b0ad9aef7da1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Louis=20Roch=C3=A9?= <louis@louisroche.net>
Date: Tue, 27 Feb 2024 14:48:16 +0100
Subject: [PATCH] turn description into atd doc

---
 lib/generator.ml |  17 +++++-
 tests/grok.t     | 140 +++++++++++++++++++++++------------------------
 tests/one_of.ml  |   1 +
 tests/smoke.t    |  18 +++---
 4 files changed, 94 insertions(+), 82 deletions(-)

diff --git a/lib/generator.ml b/lib/generator.ml
index 7e9aab4..8b0d0fe 100644
--- a/lib/generator.ml
+++ b/lib/generator.ml
@@ -6,7 +6,13 @@ let record_field_name str =
   let cleaned_field_name = Utils.sanitize_name str in
   if String.equal str cleaned_field_name then str else sprintf {|%s <json name="%s">|} cleaned_field_name str
 
-let define_type name type_ = sprintf "type %s = %s\n" (type_name name) type_
+let define_type ?doc name type_ =
+  let doc =
+    match doc with
+    | None -> ""
+    | Some doc -> sprintf {|<doc text=%S>|} doc
+  in
+  sprintf "type %s = %s %s\n" (type_name name) type_ doc
 
 let process_int_type schema =
   match schema.format with
@@ -149,7 +155,7 @@ and process_nested_schema_type ~ancestors schema =
   match merge_all_of schema with
   | { one_of = Some _; _ } | { typ = Some Object; properties = Some _; _ } | { enum = Some _; _ } ->
     let nested_type_name = concat_camelCase (List.rev ancestors) in
-    let nested = define_type nested_type_name (process_schema_type ~ancestors schema) in
+    let nested = define_type nested_type_name (process_schema_type ~ancestors schema) ?doc:schema.description in
     Buffer.add_string output (nested ^ "\n");
     type_name nested_type_name
   | _ -> process_schema_type ~ancestors schema
@@ -200,7 +206,12 @@ and process_enums enums =
 let process_schemas (schemas : (string * schema or_ref) list) =
   List.fold_left
     (fun acc (name, schema_or_ref) ->
-      define_type name (make_type_from_schema_or_ref ~ancestors:[ name ] schema_or_ref) :: acc
+      let doc =
+        match schema_or_ref with
+        | Ref _ -> None
+        | Obj schema -> schema.description
+      in
+      define_type ?doc name (make_type_from_schema_or_ref ~ancestors:[ name ] schema_or_ref) :: acc
     )
     [] schemas
 
diff --git a/tests/grok.t b/tests/grok.t
index d4b4ccf..111230b 100644
--- a/tests/grok.t
+++ b/tests/grok.t
@@ -7,83 +7,83 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
   type fieldConfigSourceOverrides = {
     matcher: matcherConfig;
     properties: dynamicConfigValue list;
-  }
+  } 
   
   type graphPanelType = [
     | Graph <json name="graph">
-  ]
+  ] 
   
   type graphPanelLegend = {
     ~show <ocaml default="true">: bool;
     ?sort: string option;
     ?sortDesc: bool option;
-  }
+  } <doc text="@deprecated this is part of deprecated graph panel">
   
   type heatmapPanelType = [
     | Heatmap <json name="heatmap">
-  ]
+  ] 
   
   type panelRepeatDirection = [
     | H <json name="h">
     | V <json name="v">
-  ]
+  ] <doc text="Direction to repeat in if 'repeat' is set.\n`h` for horizontal, `v` for vertical.">
   
   type rangeMapType = [
     | Range <json name="range">
-  ]
+  ] 
   
   type rangeMapOptions = {
     from: float;
     to_ <json name="to">: float;
     result: valueMappingResult;
-  }
+  } <doc text="Range to match against and the result to apply when the value is within the range">
   
   type regexMapType = [
     | Regex <json name="regex">
-  ]
+  ] 
   
   type regexMapOptions = {
     pattern: string;
     result: valueMappingResult;
-  }
+  } <doc text="Regular expression to match against and the result to apply when the value matches the regex">
   
   type rowPanelType = [
     | Row <json name="row">
-  ]
+  ] <doc text="The panel type">
   
   type rowPanelPanels = [
     | Panel of panel
     | GraphPanel of graphPanel
     | HeatmapPanel of heatmapPanel
-  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of">
+  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of"> 
   
   type specialValueMapType = [
     | Special <json name="special">
-  ]
+  ] 
   
   type specialValueMapOptions = {
     match_ <json name="match">: specialValueMatch;
     result: valueMappingResult;
-  }
+  } 
   
   type valueMapType = [
     | Value <json name="value">
-  ]
+  ] 
   
   type variableModelQuery = [
     | String of string
     | Json of json
-  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of">
+  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of"> <doc text="Query used to fetch values for a variable">
   
   type variableOptionText = [
     | String of string
     | StringList of string list
-  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of">
+  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of"> <doc text="Text to be displayed for the option">
   
   type variableOptionValue = [
     | String of string
     | StringList of string list
-  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of">
+  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of"> <doc text="Value of the option">
   
   type dashboardMetadata = {
     updateTimestamp: string;
@@ -96,35 +96,35 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     finalizers: string list;
     resourceVersion: string;
     labels: json;
-  }
+  } <doc text="metadata contains embedded CommonMetadata and can be extended with custom string fields\nTODO: use CommonMetadata instead of redefining here; currently needs to be defined here\nwithout external reference as using the CommonMetadata reference breaks thema codegen.">
   
   type dashboardSpecTime = {
     ~from <ocaml default="\"now-6h\"">: string;
     ~to_ <json name="to"> <ocaml default="\"now\"">: string;
-  }
+  } <doc text="Time range for dashboard.\nAccepted values are relative time strings like {from: 'now-6h', to: 'now'} or absolute time strings like {from: '2020-07-10T08:00:00.000Z', to: '2020-07-10T14:00:00.000Z'}.">
   
   type dashboardSpecTimepicker = {
     ~hidden <ocaml default="false">: bool;
     ~refresh_intervals <ocaml default="[\"5s\";\"10s\";\"30s\";\"1m\";\"5m\";\"15m\";\"30m\";\"1h\";\"2h\";\"1d\"]">: string list;
     ~collapse <ocaml default="false">: bool;
     ~time_options <ocaml default="[\"5m\";\"15m\";\"1h\";\"6h\";\"12h\";\"24h\";\"2d\";\"7d\";\"30d\"]">: string list;
-  }
+  } <doc text="Configuration of the time picker shown at the top of a dashboard.">
   
   type dashboardSpecRefresh = [
     | Bool of bool
     | String of string
-  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of">
+  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of"> <doc text="Refresh rate of dashboard. Represented via interval string, e.g. \"5s\", \"1m\", \"1h\", \"1d\".">
   
   type dashboardSpecPanels = [
     | Panel of panel
     | RowPanel of rowPanel
     | GraphPanel of graphPanel
     | HeatmapPanel of heatmapPanel
-  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of">
+  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of"> 
   
   type dashboardSpecTemplating = {
     ?list: variableModel list option;
-  }
+  } <doc text="Configured template variables">
   
   type dashboardSpec = {
     ?id: int option;
@@ -150,31 +150,31 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     ?annotations: annotationContainer option;
     ?links: dashboardLink list option;
     ?snapshot: snapshot option;
-  }
+  } 
   
   type dashboardStatus = {
     ?operatorStates: json option;
     ?additionalFields: json option;
-  }
+  } 
   
   type statusOperatorStateState = [
     | Success <json name="success">
     | In_progress <json name="in_progress">
     | Failed <json name="failed">
-  ]
+  ] <doc text="state describes the state of the lastEvaluation.\nIt is limited to three possible states for machine evaluation.">
   
   type statusOperatorState = {
     lastEvaluation: string;
     state: statusOperatorStateState;
     ?descriptiveState: string option;
     ?details: json option;
-  }
+  } 
   
   type dashboard = {
     metadata: dashboardMetadata;
     spec: dashboardSpec;
     status: dashboardStatus;
-  }
+  } 
   
   type _kubeObjectMetadata = {
     uid: string;
@@ -183,7 +183,7 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     finalizers: string list;
     resourceVersion: string;
     labels: json;
-  }
+  } <doc text="_kubeObjectMetadata is metadata found in a kubernetes object's metadata field.\nIt is not exhaustive and only includes fields which may be relevant to a kind's implementation,\nAs it is also intended to be generic enough to function with any API Server.">
   
   type variableType = [
     | Query <json name="query">
@@ -194,17 +194,17 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     | Textbox <json name="textbox">
     | Custom <json name="custom">
     | System <json name="system">
-  ]
+  ] <doc text="Dashboard variable type\n`query`: Query-generated list of values such as metric names, server names, sensor IDs, data centers, and so on.\n`adhoc`: Key/value filters that are automatically added to all metric queries for a data source (Prometheus, Loki, InfluxDB, and Elasticsearch only).\n`constant`: \tDefine a hidden constant.\n`datasource`: Quickly change the data source for an entire dashboard.\n`interval`: Interval variables represent time spans.\n`textbox`: Display a free text input field with an optional default value.\n`custom`: Define the variable options manually using a comma-separated list.\n`system`: Variables defined by Grafana. See: https://grafana.com/docs/grafana/latest/dashboards/variables/add-template-variables/#global-variables">
   
-  type variableSort = int
+  type variableSort = int <doc text="Sort variable options\nAccepted values are:\n`0`: No sorting\n`1`: Alphabetical ASC\n`2`: Alphabetical DESC\n`3`: Numerical ASC\n`4`: Numerical DESC\n`5`: Alphabetical Case Insensitive ASC\n`6`: Alphabetical Case Insensitive DESC">
   
-  type variableRefresh = int
+  type variableRefresh = int <doc text="Options to config when to refresh a variable\n`0`: Never refresh the variable\n`1`: Queries the data source every time the dashboard loads.\n`2`: Queries the data source when the dashboard time range changes.">
   
   type variableOption = {
     ?selected: bool option;
     text: variableOptionText;
     value: variableOptionValue;
-  }
+  } <doc text="Option to be selected in a variable.">
   
   type variableModel = {
     type_ <json name="type">: variableType;
@@ -220,45 +220,45 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     ?options: variableOption list option;
     ?refresh: variableRefresh option;
     ?sort: variableSort option;
-  }
+  } <doc text="A variable is a placeholder for a value. You can use variables in metric queries and in panel titles.">
   
-  type variableHide = int
+  type variableHide = int <doc text="Determine if the variable shows on dashboard\nAccepted values are 0 (show label and value), 1 (show value only), 2 (show nothing).">
   
   type valueMappingResult = {
     ?text: string option;
     ?color: string option;
     ?icon: string option;
     ?index: int option;
-  }
+  } <doc text="Result used as replacement with text and color when the value matches">
   
   type valueMapping = [
     | ValueMap of valueMap
     | RangeMap of rangeMap
     | RegexMap of regexMap
     | SpecialValueMap of specialValueMap
-  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of">
+  ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of"> <doc text="Allow to transform the visual representation of specific data values in a visualization, irrespective of their original units">
   
   type valueMap = {
     type_ <json name="type">: valueMapType;
     options: json;
-  }
+  } <doc text="Maps text values to a color or different display text and color.\nFor example, you can configure a value mapping so that all instances of the value 10 appear as Perfection! rather than the number.">
   
   type thresholdsMode = [
     | Absolute <json name="absolute">
     | Percentage <json name="percentage">
-  ]
+  ] <doc text="Thresholds can either be `absolute` (specific number) or `percentage` (relative to min or max, it will be values between 0 and 1).">
   
   type thresholdsConfig = {
     mode: thresholdsMode;
     steps: threshold list;
-  }
+  } <doc text="Thresholds configuration for the panel">
   
   type threshold = {
     value: float;
     color: string;
-  }
+  } <doc text="User-defined value for a metric that triggers visual changes in a panel when this value is met or exceeded\nThey are used to conditionally style and color visualizations based on query results , and can be applied to most visualizations.">
   
-  type target = json
+  type target = json <doc text="Schema for panel targets is specified by datasource\nplugins. We use a placeholder definition, which the Go\nschema loader either left open/as-is with the Base\nvariant of the Dashboard and Panel families, or filled\nwith types derived from plugins in the Instance variant.\nWhen working directly from CUE, importers can extend this\ntype directly to achieve the same effect.">
   
   type specialValueMatch = [
     | True_ <json name="true">
@@ -267,12 +267,12 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     | Nan <json name="nan">
     | Nullnan <json name="null+nan">
     | Empty <json name="empty">
-  ]
+  ] <doc text="Special value types supported by the `SpecialValueMap`">
   
   type specialValueMap = {
     type_ <json name="type">: specialValueMapType;
     options: specialValueMapOptions;
-  }
+  } <doc text="Maps special values like Null, NaN (not a number), and boolean values like true and false to a display text and color.\nSee SpecialValueMatch to see the list of special values.\nFor example, you can configure a special value mapping so that null values appear as N/A.">
   
   type snapshot = {
     created: string;
@@ -286,7 +286,7 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     updated: string;
     ?url: string option;
     userId: int;
-  }
+  } <doc text="A dashboard snapshot shares an interactive dashboard publicly.\nIt is a read-only version of a dashboard, and is not editable.\nIt is possible to create a snapshot of a snapshot.\nGrafana strips away all sensitive information from the dashboard.\nSensitive information stripped: queries (metric, template,annotation) and panel links.">
   
   type rowPanel = {
     type_ <json name="type">: rowPanelType;
@@ -297,17 +297,17 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     id: int;
     panels: rowPanelPanels list;
     ?repeat: string option;
-  }
+  } <doc text="Row panel">
   
   type regexMap = {
     type_ <json name="type">: regexMapType;
     options: regexMapOptions;
-  }
+  } <doc text="Maps regular expressions to replacement text and a color.\nFor example, if a value is www.example.com, you can configure a regex value mapping so that Grafana displays www and truncates the domain.">
   
   type rangeMap = {
     type_ <json name="type">: rangeMapType;
     options: rangeMapOptions;
-  }
+  } <doc text="Maps numerical ranges to a display text and color.\nFor example, if a value is within a certain range, you can configure a range value mapping to display Low or High rather than the number.">
   
   type panel = {
     type_ <json name="type">: string;
@@ -333,28 +333,28 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     ?libraryPanel: libraryPanelRef option;
     ?options: json option;
     ?fieldConfig: fieldConfigSource option;
-  }
+  } <doc text="Dashboard panels are the basic visualization building blocks.">
   
   type matcherConfig = {
     ~id <ocaml default="\"\"">: string;
     ?options: json option;
-  }
+  } <doc text="Matcher is a predicate configuration. Based on the config a set of field(s) or values is filtered in order to apply override / transformation.\nIt comes with in id ( to resolve implementation from registry) and a configuration that\226\128\153s specific to a particular matcher type.">
   
   type mappingType = [
     | Value <json name="value">
     | Range <json name="range">
     | Regex <json name="regex">
     | Special <json name="special">
-  ]
+  ] <doc text="Supported value mapping types\n`value`: Maps text values to a color or different display text and color. For example, you can configure a value mapping so that all instances of the value 10 appear as Perfection! rather than the number.\n`range`: Maps numerical ranges to a display text and color. For example, if a value is within a certain range, you can configure a range value mapping to display Low or High rather than the number.\n`regex`: Maps regular expressions to replacement text and a color. For example, if a value is www.example.com, you can configure a regex value mapping so that Grafana displays www and truncates the domain.\n`special`: Maps special values like Null, NaN (not a number), and boolean values like true and false to a display text and color. See SpecialValueMatch to see the list of special values. For example, you can configure a special value mapping so that null values appear as N/A.">
   
   type libraryPanelRef = {
     name: string;
     uid: string;
-  }
+  } <doc text="A library panel is a reusable panel that you can use in any dashboard.\nWhen you make a change to a library panel, that change propagates to all instances of where the panel is used.\nLibrary panels streamline reuse of panels across multiple dashboards.">
   
   type heatmapPanel = {
     type_ <json name="type">: heatmapPanelType;
-  }
+  } <doc text="Support for legacy heatmap panel.\n@deprecated this a deprecated panel type">
   
   type gridPos = {
     ~h <ocaml default="9">: int;
@@ -362,17 +362,17 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     ~x <ocaml default="0">: int;
     ~y <ocaml default="0">: int;
     ?static: bool option;
-  }
+  } <doc text="Position and dimensions of a panel in the grid">
   
   type graphPanel = {
     type_ <json name="type">: graphPanelType;
     ?legend: graphPanelLegend option;
-  }
+  } <doc text="Support for legacy graph panel.\n@deprecated this a deprecated panel type">
   
   type fieldConfigSource = {
     defaults: fieldConfig;
     overrides: fieldConfigSourceOverrides list;
-  }
+  } <doc text="The data model used in Grafana, namely the data frame, is a columnar-oriented table structure that unifies both time series and table query results.\nEach column within this structure is called a field. A field can represent a single time series or table column.\nField options allow you to change how the data is displayed in your visualizations.">
   
   type fieldConfig = {
     ?displayName: string option;
@@ -391,13 +391,13 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     ?links: json list option;
     ?noValue: string option;
     ?custom: json option;
-  }
+  } <doc text="The data model used in Grafana, namely the data frame, is a columnar-oriented table structure that unifies both time series and table query results.\nEach column within this structure is called a field. A field can represent a single time series or table column.\nField options allow you to change how the data is displayed in your visualizations.">
   
   type fieldColorSeriesByMode = [
     | Min <json name="min">
     | Max <json name="max">
     | Last <json name="last">
-  ]
+  ] <doc text="Defines how to assign a series color from \"by value\" color schemes. For example for an aggregated data points like a timeseries, the color can be assigned by the min, max or last value.">
   
   type fieldColorModeId = [
     | Thresholds <json name="thresholds">
@@ -415,35 +415,35 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     | Continuouspurples <json name="continuous-purples">
     | Fixed <json name="fixed">
     | Shades <json name="shades">
-  ]
+  ] <doc text="Color mode for a field. You can specify a single color, or select a continuous (gradient) color schemes, based on a value.\nContinuous color interpolates a color using the percentage of a value relative to min and max.\nAccepted values are:\n`thresholds`: From thresholds. Informs Grafana to take the color from the matching threshold\n`palette-classic`: Classic palette. Grafana will assign color by looking up a color in a palette by series index. Useful for Graphs and pie charts and other categorical data visualizations\n`palette-classic-by-name`: Classic palette (by name). Grafana will assign color by looking up a color in a palette by series name. Useful for Graphs and pie charts and other categorical data visualizations\n`continuous-GrYlRd`: ontinuous Green-Yellow-Red palette mode\n`continuous-RdYlGr`: Continuous Red-Yellow-Green palette mode\n`continuous-BlYlRd`: Continuous Blue-Yellow-Red palette mode\n`continuous-YlRd`: Continuous Yellow-Red palette mode\n`continuous-BlPu`: Continuous Blue-Purple palette mode\n`continuous-YlBl`: Continuous Yellow-Blue palette mode\n`continuous-blues`: Continuous Blue palette mode\n`continuous-reds`: Continuous Red palette mode\n`continuous-greens`: Continuous Green palette mode\n`continuous-purples`: Continuous Purple palette mode\n`shades`: Shades of a single color. Specify a single color, useful in an override rule.\n`fixed`: Fixed color mode. Specify a single color, useful in an override rule.">
   
   type fieldColor = {
     mode: fieldColorModeId;
     ?fixedColor: string option;
     ?seriesBy: fieldColorSeriesByMode option;
-  }
+  } <doc text="Map a field to a color.">
   
   type dynamicConfigValue = {
     ~id <ocaml default="\"\"">: string;
     ?value: json option;
-  }
+  } 
   
   type dataTransformerConfig = {
     id: string;
     ?disabled: bool option;
     ?filter: matcherConfig option;
     options: json;
-  }
+  } <doc text="Transformations allow to manipulate data returned by a query before the system applies a visualization.\nUsing transformations you can: rename fields, join time series data, perform mathematical operations across queries,\nuse the output of one transformation as the input to another transformation, etc.">
   
   type dataSourceRef = {
     ?type_ <json name="type">: string option;
     ?uid: string option;
-  }
+  } <doc text="Ref to a DataSource instance">
   
   type dashboardLinkType = [
     | Link <json name="link">
     | Dashboards <json name="dashboards">
-  ]
+  ] <doc text="Dashboard Link type. Accepted values are dashboards (to refer to another dashboard) and link (to refer to an external resource)">
   
   type dashboardLink = {
     title: string;
@@ -456,16 +456,16 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     ~targetBlank <ocaml default="false">: bool;
     ~includeVars <ocaml default="false">: bool;
     ~keepTime <ocaml default="false">: bool;
-  }
+  } <doc text="Links with references to other dashboards or external resources">
   
-  type dashboardCursorSync = int
+  type dashboardCursorSync = int <doc text="0 for no shared crosshair or tooltip (default).\n1 for shared crosshair.\n2 for shared crosshair AND shared tooltip.">
   
   type annotationTarget = {
     limit: int64;
     matchAny: bool;
     tags: string list;
     type_ <json name="type">: string;
-  }
+  } <doc text="TODO: this should be a regular DataQuery that depends on the selected dashboard\nthese match the properties of the \"grafana\" datasouce that is default in most dashboards">
   
   type annotationQuery = {
     name: string;
@@ -477,13 +477,13 @@ Generate ATD types from grok (Grafana Object Development Kit) dashboard types
     ?target: annotationTarget option;
     ?type_ <json name="type">: string option;
     ~builtIn <ocaml default="0">: float;
-  }
+  } <doc text="TODO docs\nFROM: AnnotationQuery in grafana-data/src/types/annotations.ts">
   
   type annotationPanelFilter = {
     ~exclude <ocaml default="false">: bool;
     ids: int list;
-  }
+  } 
   
   type annotationContainer = {
     ?list: annotationQuery list option;
-  }
+  } <doc text="Contains the list of annotations that are associated with the dashboard.\nAnnotations are used to overlay event markers and overlay event tags on graphs.\nGrafana comes with a native annotation store and the ability to add annotation events directly from the graph panel or via the HTTP API.\nSee https://grafana.com/docs/grafana/latest/dashboards/build-dashboards/annotate-visualizations/">
diff --git a/tests/one_of.ml b/tests/one_of.ml
index 506a12c..2a420a7 100644
--- a/tests/one_of.ml
+++ b/tests/one_of.ml
@@ -65,6 +65,7 @@ let nested_one_of_test _ =
       | String of string
       | Json of variableModelQueryJson
     ] <json adapter.ocaml="Jsonschema2atd_runtime.Adapter.One_of">
+      <doc text="Query used to fetch values for a variable">
 
     type variableModel = {
       ?query: variableModelQuery option;
diff --git a/tests/smoke.t b/tests/smoke.t
index 30d6344..3a681e4 100644
--- a/tests/smoke.t
+++ b/tests/smoke.t
@@ -6,7 +6,7 @@ Generate ATD out of JSON Scheme
   
   type product = {
     ?productId: int option;
-  }
+  } 
 Generate ATD out of JSON Scheme with --format attribute
   $ jsonschema2atd --format jsonschema ./mocks/simple_jsonschema.json
   (* Generated by jsonschema2atd *)
@@ -15,7 +15,7 @@ Generate ATD out of JSON Scheme with --format attribute
   
   type product = {
     ?productId: int option;
-  }
+  } 
 Generate ATD out of JSON Scheme with -f attribute
   $ jsonschema2atd -f jsonschema ./mocks/simple_jsonschema.json
   (* Generated by jsonschema2atd *)
@@ -24,7 +24,7 @@ Generate ATD out of JSON Scheme with -f attribute
   
   type product = {
     ?productId: int option;
-  }
+  } 
 Generate ATD out of OpenAPI doc with --format attribute
   $ jsonschema2atd --format openapi ./mocks/simple_openapi.json
   (* Generated by jsonschema2atd *)
@@ -33,7 +33,7 @@ Generate ATD out of OpenAPI doc with --format attribute
   
   type product = {
     ?productId: int option;
-  }
+  } 
 Generate ATD out of OpenAPI doc with -f attribute
   $ jsonschema2atd -f openapi ./mocks/simple_openapi.json
   (* Generated by jsonschema2atd *)
@@ -42,7 +42,7 @@ Generate ATD out of OpenAPI doc with -f attribute
   
   type product = {
     ?productId: int option;
-  }
+  } 
 
 Generate ATD out of JSON Schema that contains defs
   $ jsonschema2atd --format=jsonschema ./mocks/jsonchema_defs.json
@@ -50,12 +50,12 @@ Generate ATD out of JSON Schema that contains defs
   type json <ocaml module="Yojson.Basic" t="t"> = abstract
   type int64 = int <ocaml repr="int64">
   
-  type name = string
+  type name = string 
   
   type root = {
     first_name: name;
     last_name: name;
-  }
+  } 
 
 Generate ATD out of JSON Schema that contains definitions (legacy support)
   $ jsonschema2atd --format=jsonschema ./mocks/jsonchema_definitions.json
@@ -63,9 +63,9 @@ Generate ATD out of JSON Schema that contains definitions (legacy support)
   type json <ocaml module="Yojson.Basic" t="t"> = abstract
   type int64 = int <ocaml repr="int64">
   
-  type name = string
+  type name = string 
   
   type root = {
     first_name: name;
     last_name: name;
-  }
+  }