Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify default S3 path strategy #37

Open
agritheory opened this issue Jul 24, 2023 · 0 comments
Open

Modify default S3 path strategy #37

agritheory opened this issue Jul 24, 2023 · 0 comments
Assignees
@Alchez @MyuddinKhatri
Labels
enhancement New feature or request version-15

Comments

@agritheory
Copy link
Owner

agritheory commented Jul 24, 2023 •
edited
Loading

The use case for making a date/doctype/docname flavor of S3 path has multiple issues:

  • Verbose
  • Makes less sense in the context of the file association features
  • Makes paths more guessable (employee/employee_id/contract.pdf)
  • Nobody is or really should be using the S3/Spaces UI to browse files

Switch to using the name of the File record

Allow configuration of file path with a hookable function in case there's a customer reason to customize this (for example an FTP integration)
@agritheory agritheory added the enhancement New feature or request label Jul 24, 2023
@agritheory agritheory changed the title Modify S3 path strategy Modify default S3 path strategy Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alchez Alchez

@MyuddinKhatri MyuddinKhatri

Labels
enhancement New feature or request version-15
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Alchez @agritheory @MyuddinKhatri