feat(contractStarter): providing terms, privateArgs to started contracts #17

dckc · 2024-01-14T21:57:44Z

Smart wallet offers can only refer to objects that are

on the board, and
mentioned in vstorage

For low-privilege services such as namesByAddress, we

add them to the terms of contractStarter,
publish the terms of the contractStarter as auxiliary data of the instance using boardAux conventions

For limited services (currently: storageNode and timerService), we add a permit property to offerArgs.

timerService: true results in privateArgs of the form { timerService: chainTimerService }.
storageNode: 'boardAux' causes a initStorageNode(node) call to the creatorFacet where
node is a StorageNode at published.boardAux.${instanceBoardId}.info. It's not feasible to supply this in privateArgs since the instance is not known until after the contract starts.

We add prices for

installBundleID call, if used
the startInstance call
each of the permit properties/keys

launched to local chain

note: I avoided a 2nd bundle. see also #19

6d3ea2d

ag-power-tools-agd-1  | 2024-01-16T06:51:29.480Z SwingSet: vat: v1: installation contractStarter settled; remaining: []
ag-power-tools-agd-1  | 2024-01-16T06:51:30.867Z SwingSet: vat: v1: contractStarterKit: new Promise
ag-power-tools-agd-1  | 2024-01-16T06:51:30.870Z SwingSet: vat: v1: contractStarterKit settled; remaining: [ 'anchorKits', 'bankMints', 'contractGovernor', 'reserveGovernorCreatorFacet', 'scaledPriceAuthorityKits', 'vBankKits', 'vaultFactoryGovernorCreator' ]
ag-power-tools-agd-1  | 2024-01-16T06:51:30.890Z SwingSet: vat: v1: instance contractStarter: new Promise
ag-power-tools-agd-1  | 2024-01-16T06:51:30.893Z SwingSet: vat: v1: instance contractStarter settled; remaining: []

TODO: print boardID?

I see it in published.agoricNames.installation and .instance as contractStarter.

published.boardAux.board00694 shows:

{
  "terms": {
    "agoricNames": {},
    "board": {},
    "brands": {
      "Fee": {},
      "Invitation": {}
    },
    "issuers": {
      "Fee": {},
      "Invitation": {}
    },
    "namesByAddress": {},
    "priceAuthority": {},
    "prices": {
      "installBundleID": {
        "brand": {},
        "value": "0"
      },
      "startInstance": {
        "brand": {},
        "value": "0"
      },
      "storageNode": {
        "brand": {},
        "value": "0"
      },
      "timerService": {
        "brand": {},
        "value": "0"
      }
    }
  }
}

dckc · 2024-01-21T05:05:05Z

contract/src/contractStarter.js

        instanceLabel,
      );
      // WARNING: adminFacet is dropped
      const { instance, creatorFacet } = it;

+      const itsTerms = await E(zoe).getTerms(instance);
+      const itsId = await E(board).getId(instance);


nothing is putting the installation on the board:

{ installation: Object [Alleged: BundleIDInstallation#null] {}, instance: Object [Alleged: InstanceHandle#board064124] {} }

- main - emitPermit

…EST) - refactor: use seatLike to clarify starterSam - start-contractStarer: use fixHub on namesByAddress - factor fixHub out of start-postalSvc - deprecate startPostalSvc - contractStarter: document storage schema - move board, priceAuthority to limitedAccess etc. - include labels

dckc requested a review from 0xpatrickdev January 14, 2024 21:57