Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No synchronization between PullRequest instance and underlying Issue instance #41

Open
liaham opened this issue May 18, 2020 · 0 comments

Comments

@liaham
Copy link

liaham commented May 18, 2020

Hello,

I feel happy about your redmine plugin. It meets perfectly my needs. Thank you very much!

Creating a PR icon on a Redmine issue works

I noticed that you refer to the webhook key ref in the payload. Therefore, I created a branch name with a prepended @, e.g., feature-@4, on GitHub. This branch contained my commits I liked to merge via PR.

Changing the Redmine issue icon after merging the PR is not working

When I merged the 'feature-@4' branch into master (on GitHub), I expected the PR status to be changed to merged, but it was not.

As far as I understand from your code, this will never happen since accepting a PR on GitHub is a push event, which again requires an issue reference in the ref key to be fetched by your plugin and finally marked as merged.

Therefore, I created a branch with a name that contains the issue reference as described above. However, when I tryed to merge into this branch instead of master branch, again, nothing has happend to the Redmine issue icon.

Usually, I would debug by myself. However, I installed your plugin into production environment without a gem for debugging.

Can you help me, please?

Thanks a lot!
Liane

Technical details

Environment:
Redmine version 4.1.1.stable
Ruby version 2.6.6-p146 (2020-03-31) [x86_64-linux]
Rails version 5.2.4.2
Environment production
Database adapter Mysql2
Mailer queue ActiveJob::QueueAdapters::AsyncAdapter
Mailer delivery smtp
SCM:
Subversion 1.8.10
Git 2.1.4
Filesystem
Github 2.1.4
Redmine plugins:
redmine_custom_footer 0.4.0
redmine_github 0.0.1
redmine_pulls 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant