From 80626f891355de0cf9f515e9b61424037c4c530b Mon Sep 17 00:00:00 2001
From: Stakovicz <albin@les-tilleuls.coop>
Date: Sun, 17 Nov 2024 21:16:54 +0100
Subject: [PATCH] fix phpstan

---
 phpstan.neon                                  |  7 +++++
 .../Afup/Bootstrap/Simpletest/Functional.php  | 31 -------------------
 sources/Afup/Bootstrap/Simpletest/Unit.php    |  4 ---
 sources/Afup/Utils/Configuration.php          |  2 +-
 .../Controller/SiteBaseController.php         |  3 --
 5 files changed, 8 insertions(+), 39 deletions(-)
 delete mode 100644 sources/Afup/Bootstrap/Simpletest/Functional.php
 delete mode 100644 sources/Afup/Bootstrap/Simpletest/Unit.php

diff --git a/phpstan.neon b/phpstan.neon
index feecb0fbe..21f665cd4 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -14,3 +14,10 @@ parameters:
             # Ces fichiers utilisent des alias de classes
             - sources/AppBundle/Twig/AssetsExtension.php
             - sources/AppBundle/Twig/TwigExtension.php
+
+    ignoreErrors:
+        -
+            message: '#^Method AppBundle\\Controller\\SiteBaseController\:\:render\(\) overrides @final method Symfony\\Bundle\\FrameworkBundle\\Controller\\Controller\:\:render\(\)\.$#'
+            identifier: method.parentMethodFinalByPhpDoc
+            count: 1
+            path: sources/AppBundle/Controller/SiteBaseController.php
diff --git a/sources/Afup/Bootstrap/Simpletest/Functional.php b/sources/Afup/Bootstrap/Simpletest/Functional.php
deleted file mode 100644
index 58e3ef2ca..000000000
--- a/sources/Afup/Bootstrap/Simpletest/Functional.php
+++ /dev/null
@@ -1,31 +0,0 @@
-<?php
-/**
- * Fichier (bootstrap) du contexte tests fonctionnels avec SimpleTest
- * 
- * Ce fichier doit contenir l'ensemble des directives d'initialisation
- * nécessaire au chargement de toute l'application pour une exécution
- * de script de tests fonctionnels
- * 
- * Ce fichier est systématiquement à inclure en haut de chaque
- * script de test.
- * 
- * @author    Perrick Penet   <perrick@noparking.fr>
- * @author    Olivier Hoareau <olivier@phppro.fr>
- * @copyright 2010 Association Française des Utilisateurs de PHP
- * 
- * @category AFUP
- * @package  AFUP
- * @group    Bootstraps
- */
-
-// chargement des paramétrages génériques / multi-contextuels de l'application
-
-require_once dirname(__FILE__) . '/_Common.php';
-
-define('CHEMIN_APPLICATION', 'http://localhost/gestafup/trunk/site/');
-
-
-
-require_once 'simpletest/web_tester.php';
-require_once 'simpletest/reporter.php';
-require_once 'simpletest/browser.php';
\ No newline at end of file
diff --git a/sources/Afup/Bootstrap/Simpletest/Unit.php b/sources/Afup/Bootstrap/Simpletest/Unit.php
deleted file mode 100644
index 2c45e0189..000000000
--- a/sources/Afup/Bootstrap/Simpletest/Unit.php
+++ /dev/null
@@ -1,4 +0,0 @@
-<?php
-
-require_once dirname(__FILE__)."/../_Common.php";
-require_once dirname(__FILE__)."/../../../../tests/simpletest/autorun.php";
\ No newline at end of file
diff --git a/sources/Afup/Utils/Configuration.php b/sources/Afup/Utils/Configuration.php
index 3448b35bb..f226eebda 100644
--- a/sources/Afup/Utils/Configuration.php
+++ b/sources/Afup/Utils/Configuration.php
@@ -61,6 +61,6 @@ private function loadSymfonyParameters(): array
 
     public function obtenir($cle)
     {
-        return self::$values[$cle];
+        return self::$values[$cle] ?? null;
     }
 }
diff --git a/sources/AppBundle/Controller/SiteBaseController.php b/sources/AppBundle/Controller/SiteBaseController.php
index d90333a0a..3edefc761 100644
--- a/sources/AppBundle/Controller/SiteBaseController.php
+++ b/sources/AppBundle/Controller/SiteBaseController.php
@@ -25,9 +25,6 @@ public function setDefaultBlocks(array $blocks)
         $this->defaultBlocks = $blocks;
     }
 
-    /**
-     * @param Configuration $conf
-     */
     public function setConfiguration(Configuration $conf)
     {
         $this->legacyConfiguration = $conf;