Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selectable map regions #59

Closed
wants to merge 3 commits into from
Closed

Conversation

yohannesHL
Copy link
Collaborator

Closes #51
@helomberhane @yohane55

Updated map (as i had already started working on it 😃 )
Add support for onRegionClick and onRegionHover events for other charts to hook on
This is still using leaflet and openstreet maps ( so no need for API licences).

@yohannesHL
Copy link
Collaborator Author

localhost_8000_

@helomberhane
Copy link
Collaborator

I would hold on merging this in, we'll need to coordinate how/where to fit this into the current layout.

@yohane55
Copy link
Contributor

yohane55 commented Apr 9, 2020

@yohannesHL and @helomberhane you both did good on the map!! @helomberhane is there any update on Gmap api free credit?

I think it is good to have both regional and zonal geojson and case/medical facility data.

@yohannesHL
Copy link
Collaborator Author

@helomberhane @yohane55 Think i misunderstood and thought that we only needed admin regions not woredas. But it should be possible to show woredas on the region via click handler (similar to https://ws456999.github.io/vue-echarts-map-drill-down/#/). Currently it zooms in to the region but we can render the woreda overlay too.

@yohane55
Copy link
Contributor

yohane55 commented Apr 9, 2020

@yohannesHL In my opinion that seems the right approach for showing number of cases, but for health facilities we still can use the woreda/zonal geojeson.

@yohane55
Copy link
Contributor

@helomberhane can we continue working on leaflet? can you re-do your changes on leaflet??

@yohannesHL yohannesHL force-pushed the feature/regional-map branch from ff93881 to 6afe0ac Compare April 15, 2020 21:32
@yohannesHL
Copy link
Collaborator Author

@helomberhane Can you have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update heatmap for cases by region at the woreda level and restrict map to Ethiopia.
3 participants